Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Add incoming notes filter

In a Release build Task General Zcash support

Lead item brave-browser#44249 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#27826 merged 2025-03-04 into master by cypt4
    [ZCash] Add incoming notes filter
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_44249 (weaker evidence; titles share a keyword)

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.77.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...cd1c1fdf: behind); later builds of the same history include it (brave-core#27826)

Members and their history

Issue

brave-browser#44249 [Zcash] Add incoming notes filter

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:shielded wallet, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Incoming notes should be filtered by distance to the latest scanned block. We should filter internal notes that are less than 3 blocks to the latest scanned block and 10 for external. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards…

Timeline (10 of 13 events)
  1. 2025-02-26 16:56 Label added OS/Desktop by cypt4
  2. 2025-02-26 18:58 Referenced by brave-core#27826 by cypt4
  3. 2025-03-04 18:38 Closed completed brave-core#27826 by cypt4
  4. 2025-03-04 18:39 Milestone set 1.78.x - Nightly by brave-builds
  5. 2025-03-05 08:44 Label added QA/Yes by cypt4
  6. 2025-03-05 08:44 Label added release-notes/exclude by cypt4
  7. 2025-03-06 20:56 Referenced by brave-core#28012 by brave-builds
  8. 2025-03-07 13:03 Milestone removed 1.78.x - Nightly by brave-builds
  9. 2025-03-07 13:03 Milestone set 1.77.x - Beta by brave-builds
  10. 2025-03-26 08:45 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#27826 [ZCash] Add incoming notes filter

State: merged 2025-03-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/44249 Anchor selection logic is refactored. Now spendable notes bundle is returned along with suggested anchor block id. Spendable notes are filtered by the confirmations count to the latest scanned block. Added pending balance message to the sync banner. [image] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ]…

Timeline (6 of 10 events)
  1. 2025-02-27 19:13 Ready for review by cypt4
  2. 2025-03-04 18:38 Merged master by cypt4
  3. 2025-03-04 18:38 Closed by cypt4
  4. 2025-03-04 18:38 Milestone set 1.78.x - Nightly by github-actions
  5. 2025-03-06 20:56 Referenced by brave-core#28012 by brave-builds
  6. 2025-03-26 08:45 Referenced by brave-browser#44249 by srirambv
Uplift PR → 1.77.x

brave-core#28012 [ZCash] Add incoming notes filter (uplift to 1.77.x)

State: merged 2025-03-07 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of #27826 Resolves https://github.com/brave/brave-browser/issues/44249 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 6 events)
  1. 2025-03-06 20:56 Milestone set 1.77.x - Beta by brave-builds
  2. 2025-03-07 13:02 Merged 1.77.x by LaurenWags
  3. 2025-03-07 13:02 Closed by LaurenWags