Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Only show/enable sync account button if there are pending blocks to be synced

In a Release build Bug Sync, scanning & storage

Lead item brave-browser#44205 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#27811 merged 2025-02-26 into master by Douglashdaniel
    fix(wallet): Don't Show Sync Warning for Zero Blocks Behind
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.77.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...37ada217: behind); later builds of the same history include it (brave-core#27811)

Members and their history

Issue

brave-browser#44205 Only show/enable sync account button if there are pending blocks to be synced

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash · matched label:feature/web3/wallet/zcash, body:shielded

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/zcash

Description Only show/enable sync account button if there are pending blocks to be synced Steps to reproduce 1. Enable shielded account 2. Shows Sync button to sync account 3. Finish Sync process 4. Account shows 0 blocks left message 5. Click on Sync account again 6. Shows Sync error Actual result [GitHub link omitted] Expected result Should only enable/show the Sync account button when there are pending blocks to sync Reproduces how often Easily reproduced Brave version…

Timeline (7 of 10 events)
  1. 2025-02-25 12:31 Label added OS/Desktop by srirambv
  2. 2025-02-25 12:31 Label added QA/Yes by srirambv
  3. 2025-02-25 12:31 Label added release-notes/exclude by srirambv
  4. 2025-02-26 00:25 Referenced by brave-core#27811 by Douglashdaniel
  5. 2025-02-26 15:37 Closed completed brave-core#27811 by Douglashdaniel
  6. 2025-02-26 15:37 Milestone set 1.77.x - Nightly by brave-builds
  7. 2025-03-19 10:33 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#27811 fix(wallet): Don't Show Sync Warning for Zero Blocks Behind

State: merged 2025-02-26 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet

Description Will now only show the Zcash Sync warning if the Blocks Behind is greater than 0 Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that…

Timeline (4 of 6 events)
  1. 2025-02-26 15:37 Merged master by Douglashdaniel
  2. 2025-02-26 15:37 Closed by Douglashdaniel
  3. 2025-02-26 15:37 Milestone set 1.77.x - Nightly by github-actions
  4. 2025-03-19 10:32 Referenced by brave-browser#44205 by srirambv