Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Disable Send from shielded to transparent address

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#44055 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#27994 merged 2025-03-06 into master by Douglashdaniel
    feat(wallet): Add Shielding to Send Flow
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.77.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...5a3b09a6: behind); later builds of the same history include it (brave-core#27994)

Members and their history

Issue

brave-browser#44055 Disable Send from shielded to transparent address

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash · matched label:feature/web3/wallet/zcash, title:shielded, body:shielded

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Disable Send from shielded to transparent address Steps to reproduce 1. Enable shielded account 2. Initiate send from shielded token to transparent 3. Allows to send Actual result Able to send from orchard to transparent address Expected result Disable Send from shielded to transparent address Reproduces how often Easily reproduced Brave version (brave://version info) Brave | 1.77.42 Chromium: 133.0.6943.98 (Official Build) nightly (64-bit) -- | -- Revision |…

Timeline (10 of 13 events)
  1. 2025-02-18 11:38 Label added OS/Desktop by srirambv
  2. 2025-02-18 11:38 Label added QA/Yes by srirambv
  3. 2025-02-18 11:38 Label added release-notes/exclude by srirambv
  4. 2025-03-06 01:26 Referenced by brave-core#27994 by Douglashdaniel
  5. 2025-03-06 21:45 Closed completed brave-core#27994 by Douglashdaniel
  6. 2025-03-06 21:46 Milestone set 1.78.x - Nightly by brave-builds
  7. 2025-03-12 14:54 Referenced by brave-core#28105 by kjozwiak
  8. 2025-03-13 18:40 Milestone removed 1.78.x - Nightly by brave-builds
  9. 2025-03-13 18:40 Milestone set 1.77.x - Beta by brave-builds
  10. 2025-03-18 12:27 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#27994 feat(wallet): Add Shielding to Send Flow

State: merged 2025-03-06 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Description - Will now allow users to select their Shielded account address in the Send flow to easily shield funds. - Also disables the ability to send from a Shielded account to a Transparent account Resolves Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above -…

Timeline (6 of 9 events)
  1. 2025-03-06 21:45 Merged master by Douglashdaniel
  2. 2025-03-06 21:45 Closed by Douglashdaniel
  3. 2025-03-06 21:45 Milestone set 1.78.x - Nightly by github-actions
  4. 2025-03-12 07:17 Referenced by brave-core#28105 by cypt4
  5. 2025-03-12 13:30 Referenced by brave-core#28046 by cypt4
  6. 2025-03-18 10:26 Referenced by brave-browser#42250 by srirambv
Uplift PR → 1.77.x

brave-core#28105 [ZCash] Uplift pr28046 and pr27994 (1.77.x)

State: merged 2025-03-13 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of https://github.com/brave/brave-core/pull/27994 Uplift of https://github.com/brave/brave-core/pull/28046 Resolves https://github.com/brave/brave-browser/issues/42250 Resolves https://github.com/brave/brave-browser/issues/44055 Resolves https://github.com/brave/brave-browser/issues/44541 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my…

Timeline (3 of 6 events)
  1. 2025-03-12 14:52 Milestone set 1.77.x - Beta by kjozwiak
  2. 2025-03-13 18:39 Merged 1.77.x by kjozwiak
  3. 2025-03-13 18:39 Closed by kjozwiak