Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Cleanup dependencies on HD Keyring

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#43981 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#27663 merged 2025-02-18 into master by supermassive
    Drop HDKeyring base class
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.77.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...28ea5347: behind); later builds of the same history include it (brave-core#27663)

Members and their history

Issue

brave-browser#43981 Cleanup dependencies on HD Keyring

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#27663

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/cardano

Description Cleanup wallet dependencies on HD Keyring so introducing cardano account would be easier.

Timeline (6 of 10 events)
  1. 2025-02-14 09:08 Label added OS/Desktop by supermassive
  2. 2025-02-14 09:08 Label added QA/No by supermassive
  3. 2025-02-14 09:08 Label added release-notes/exclude by supermassive
  4. 2025-02-14 09:08 Referenced by brave-core#27663 by supermassive
  5. 2025-02-18 14:06 Closed completed brave-core#27663 by supermassive
  6. 2025-02-18 14:07 Milestone set 1.77.x - Nightly by brave-builds
Pull request

brave-core#27663 Drop HDKeyring base class

State: merged 2025-02-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/43981 Keyrings for all coins tend to have more differences than in common. Having base HDKeyring class just makes things harder to extend. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit…

Timeline (3 of 7 events)
  1. 2025-02-18 14:06 Merged master by supermassive
  2. 2025-02-18 14:06 Closed by supermassive
  3. 2025-02-18 14:07 Milestone set 1.77.x - Nightly by github-actions