Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Fix crash when sending from orchard to transparent address

In a Release build Bug Security & hardening

Lead item brave-browser#43815 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#27560 merged 2025-02-12 into master by cypt4
    [ZCash] refactor recipient address verification
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_43815 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.77.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...1d6cc7fe: behind); later builds of the same history include it (brave-core#27560)

Members and their history

Issue

brave-browser#43815 [Zcash] Fix crash when sending from orchard to transparent address

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:orchard, body:orchard

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Fix crash when sending from orchard to transparent address Steps to reproduce 1. Select shielded token to send 2. Use transparent address as the recipient Actual result Error message should be shown Expected result Error when send transaction Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards…

Timeline (8 of 11 events)
  1. 2025-02-07 14:02 Label added OS/Desktop by cypt4
  2. 2025-02-07 14:02 Label added QA/Yes by cypt4
  3. 2025-02-07 14:02 Label added release-notes/exclude by cypt4
  4. 2025-02-07 15:15 Referenced by brave-core#27560 by cypt4
  5. 2025-02-12 19:38 Closed completed brave-core#27560 by cypt4
  6. 2025-02-12 19:38 Closed completed by cypt4
  7. 2025-02-12 19:38 Milestone set 1.77.x - Nightly by brave-builds
  8. 2025-03-24 06:28 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#27560 [ZCash] refactor recipient address verification

State: merged 2025-02-12 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Fixes https://github.com/brave/brave-browser/issues/43815 Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in…

Timeline (4 of 8 events)
  1. 2025-02-10 20:22 Ready for review by cypt4
  2. 2025-02-12 19:38 Merged master by cypt4
  3. 2025-02-12 19:38 Closed by cypt4
  4. 2025-02-12 19:38 Milestone set 1.77.x - Nightly by github-actions