Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Truncate shard tree on reorg event

In a Release build Task Sync, scanning & storage

Lead item brave-browser#43402 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#27293 merged 2025-01-23 into master by cypt4
    [ZCash] Truncate shard tree on chain reorg event
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_43402 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.76.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...802e264b: behind); later builds of the same history include it (brave-core#27293)

Members and their history

Issue

brave-browser#43402 [Zcash] Truncate shard tree on reorg event

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Shard tree should be truncated to the minimal checkpoint id along with the information about discovered notes. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No…

Timeline (7 of 10 events)
  1. 2025-01-21 17:52 Label added OS/Desktop by cypt4
  2. 2025-01-21 17:52 Label added QA/No by cypt4
  3. 2025-01-21 17:52 Label added release-notes/exclude by cypt4
  4. 2025-01-21 17:54 Referenced by brave-core#27293 by cypt4
  5. 2025-01-23 17:19 Closed completed brave-core#27293 by cypt4
  6. 2025-01-23 17:19 Closed completed by cypt4
  7. 2025-01-23 17:19 Milestone set 1.76.x - Nightly by brave-builds
Pull request

brave-core#27293 [ZCash] Truncate shard tree on chain reorg event

State: merged 2025-01-23 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/43402 1) Shard tree modifications are now in the transaction scope along with related direct database modifications. 2) Reorg flow changed a bit. Now minimum check-pointed height is used. Since at one time we have 100 checkpoints it is safe to rewind to such block height. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them…

Timeline (4 of 6 events)
  1. 2025-01-22 20:03 Ready for review by cypt4
  2. 2025-01-23 17:19 Merged master by cypt4
  3. 2025-01-23 17:19 Closed by cypt4
  4. 2025-01-23 17:19 Milestone set 1.76.x - Nightly by github-actions