Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Suggested Zcash account name should not have a capital C

In release notes Bug Addresses, accounts & memos

Lead item brave-browser#43278 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#27222 merged 2025-01-14 into master by Douglashdaniel
    fix(wallet): Don't Capitalize c in Zcash Account Name Suggestion
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.76.73: “Fixed casing for Zcash on the "Accounts" page. (#43278)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.76.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...5869407e: behind); later builds of the same history include it (brave-core#27222)

Members and their history

Issue

brave-browser#43278 [ZCash] Suggested Zcash account name should not have a capital C

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/zcash

Description Currently when you go to create a new Zcash account the C is capitalized for the Suggested Name example(ZCash Account 2) Steps to reproduce 1. Go to the Accounts tab and then click to create a new Zcash account 2. The suggested name has a capital C in Zcash Actual result [GitHub link omitted] Expected result c should not be capitalized in Zcash [GitHub link omitted] Reproduces how often Easily reproduced Brave version (brave://version info) 1.73.104 Chromium:…

Timeline (8 of 12 events)
  1. 2025-01-14 03:11 Label added OS/Desktop by Douglashdaniel
  2. 2025-01-14 03:11 Label added QA/Yes by Douglashdaniel
  3. 2025-01-14 03:11 Label added release-notes/include by Douglashdaniel
  4. 2025-01-14 03:17 Referenced by brave-core#27222 by Douglashdaniel
  5. 2025-01-14 14:35 Closed completed brave-core#27222 by Douglashdaniel
  6. 2025-01-14 14:35 Milestone set 1.76.x - Nightly by brave-builds
  7. 2025-02-24 06:03 Label added QA Pass-Win64 by srirambv
  8. 2025-03-04 15:59 Referenced by brave-browser#44402 by LaurenWags
Pull request

brave-core#27222 fix(wallet): Don't Capitalize c in Zcash Account Name Suggestion

State: merged 2025-01-14 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet

Description Fixes a bug where the c was being capitalized in Zcash account name suggestions. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that…

Timeline (4 of 6 events)
  1. 2025-01-14 14:35 Merged master by Douglashdaniel
  2. 2025-01-14 14:35 Closed by Douglashdaniel
  3. 2025-01-14 14:35 Milestone set 1.76.x - Nightly by github-actions
  4. 2025-02-24 06:03 Referenced by brave-browser#43278 by srirambv