Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

DEPS has many overly broad rules

In a Release build Issue General Zcash support

Lead item brave-browser#43250 · opened by bridiver · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#27193 merged 2025-01-13 into master by bridiver
    fix overly permissive DEPS
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.76.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: bridiver · PR authors: bridiver

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...afd4e023: behind); later builds of the same history include it (brave-core#27193)

Members and their history

Issue

brave-browser#43250 DEPS has many overly broad rules

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#27193

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

We currently have overly broad rules that don't prevent things like using brave/renderer code in brave/browser and other similar issues. It's also problematic because our chromium process directories are actually at the top level instead of inside another directory like chrome.

Timeline (6 of 9 events)
  1. 2025-01-13 00:19 Referenced by brave-core#27193 by bridiver
  2. 2025-01-13 00:20 Label added QA/No by bridiver
  3. 2025-01-13 00:20 Label added release-notes/exclude by bridiver
  4. 2025-01-13 04:43 Closed completed brave-core#27193 by bridiver
  5. 2025-01-13 04:43 Milestone set 1.76.x - Nightly by brave-builds
  6. 2025-01-13 13:22 Label added OS/Desktop by bridiver
Pull request

brave-core#27193 fix overly permissive DEPS

State: merged 2025-01-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/run-network-audit CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/43250 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (4 of 9 events)
  1. 2025-01-13 04:43 Merged master by bridiver
  2. 2025-01-13 04:43 Closed by bridiver
  3. 2025-01-13 04:43 Milestone set 1.76.x - Nightly by github-actions
  4. 2025-03-03 05:45 Referenced by brave-core#27878 by mherrmann