Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Cleanup HDKey

In a Release build Issue General Zcash support

Lead item brave-browser#43110 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#27118 merged 2025-01-09 into master by supermassive
    HD Key cleanup
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.76.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...df7d7cf0: behind); later builds of the same history include it (brave-core#27118)

Members and their history

Issue

brave-browser#43110 Cleanup HDKey

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#27118

OS/Windows QA/No dev-concern release-notes/exclude feature/web3/wallet feature/web3/wallet/core

Description Cleanup HDKey

Timeline (6 of 9 events)
  1. 2025-01-06 04:12 Label added OS/Windows by supermassive
  2. 2025-01-06 04:12 Label added QA/No by supermassive
  3. 2025-01-06 04:12 Label added release-notes/exclude by supermassive
  4. 2025-01-06 04:13 Referenced by brave-core#27118 by supermassive
  5. 2025-01-09 05:38 Closed completed brave-core#27118 by supermassive
  6. 2025-01-09 05:38 Milestone set 1.76.x - Nightly by brave-builds
Pull request

brave-core#27118 HD Key cleanup

State: merged 2025-01-09 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/43110 - Remove support of string HD path. Use utility DerivationIndex instead. - Move parsing of ImportAccountFromJson payload to separate file. - Cleanup HDKey interface and implementation(spans, SpanReader/SpanWriter, etc) Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used…

Timeline (4 of 7 events)
  1. 2025-01-06 04:20 Ready for review by supermassive
  2. 2025-01-09 05:38 Merged master by supermassive
  3. 2025-01-09 05:38 Closed by supermassive
  4. 2025-01-09 05:38 Milestone set 1.76.x - Nightly by github-actions