Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Unable to send from transparent to shielded account

In release notes Bug Shielded (Orchard) support

Lead item brave-browser#42951 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#27089 merged 2024-12-24 into master by cypt4
    [ZCash] Fetch consensus branch id from the backend
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_42951 (weaker evidence; titles share a keyword)

Uplifts to release branches

Release notes

  • Desktop 1.73.105: “Fixed "Send" transactions not working for transparent address in certain scenarios. (#42951)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.73.x - Release #7

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: unassigned · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...1c9725de: behind); later builds of the same history include it (brave-core#27089)

Members and their history

Issue

brave-browser#42951 [ZCash] Unable to send from transparent to shielded account

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:shielded, body:zcash

bug QA Pass-Win64 priority/P2 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Unable to send from transparent to shielded account Steps to reproduce 1. Create 2 ZCash accounts 2. Make one account as Shielded 3. Send from transparent account to Shielded account 4. Shows transparent account address for Shielded account in receiving account 5. Submit Send transaction 6. Doesn't confirm transaction Actual result Unable to send from transparent to shielded account Expected result Should be able to send transaction from transparent address…

Timeline (15 of 21 events)
  1. 2024-12-18 16:13 Label added OS/Desktop by srirambv
  2. 2024-12-18 16:13 Label added QA/Yes by srirambv
  3. 2024-12-18 16:13 Label added release-notes/exclude by srirambv
  4. 2024-12-23 21:33 Referenced by brave-core#27089 by cypt4
  5. 2024-12-24 10:32 Label added priority/P2 by cypt4
  6. 2024-12-24 13:09 Closed completed brave-core#27089 by cypt4
  7. 2024-12-24 13:10 Milestone set 1.75.x - Nightly by brave-builds
  8. 2024-12-28 21:40 Referenced by brave-core#27092 by kjozwiak
  9. 2024-12-28 21:40 Referenced by brave-core#27094 by kjozwiak
  10. 2025-01-06 08:38 Milestone removed 1.75.x - Nightly by brave-builds
  11. 2025-01-06 08:38 Milestone set 1.74.x - Beta by brave-builds
  12. 2025-01-06 08:38 Milestone removed 1.74.x - Beta by brave-builds
  13. 2025-01-06 08:38 Milestone set 1.73.x - Release #7 by brave-builds
  14. 2025-01-08 13:05 Label added QA Pass-Win64 by srirambv
  15. 2025-01-08 15:19 Referenced by brave-browser#43172 by LaurenWags
Pull request

brave-core#27089 [ZCash] Fetch consensus branch id from the backend

State: merged 2024-12-24 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:shielded is:pr, search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/42951 Testplan : Test transparent transactions to be working Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before…

Timeline (5 of 7 events)
  1. 2024-12-24 13:09 Merged master by cypt4
  2. 2024-12-24 13:09 Closed by cypt4
  3. 2024-12-24 13:10 Milestone set 1.75.x - Nightly by github-actions
  4. 2024-12-25 10:44 Referenced by brave-core#27092 by cypt4
  5. 2024-12-25 12:39 Referenced by brave-core#27094 by cypt4
Uplift PR → 1.73.x

brave-core#27094 [ZCash] Fetch consensus branch id from the backend - 1.73.x

State: merged 2025-01-06 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Uplift for https://github.com/brave/brave-core/pull/27089 Fixes https://github.com/brave/brave-browser/issues/42951 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before…

Timeline (3 of 5 events)
  1. 2024-12-28 21:40 Milestone set 1.73.x - Release #7 by kjozwiak
  2. 2025-01-06 08:38 Merged 1.73.x by kjozwiak
  3. 2025-01-06 08:38 Closed by kjozwiak
Uplift PR → 1.74.x

brave-core#27092 [ZCash] Fetch consensus branch id from the backend - 1.74.x

State: merged 2025-01-06 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Uplift for https://github.com/brave/brave-core/pull/27089 Fixes https://github.com/brave/brave-browser/issues/42951 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before…

Timeline (3 of 5 events)
  1. 2024-12-28 21:40 Milestone set 1.74.x - Beta by kjozwiak
  2. 2025-01-06 08:38 Merged 1.74.x by kjozwiak
  3. 2025-01-06 08:38 Closed by kjozwiak