Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Implement spending of shielded inputs

In a Release build Task Shielded (Orchard) support

Lead item brave-browser#42898 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#27018 merged 2025-01-22 into master by cypt4
    [ZCash] Implement Zcash Orchard inputs spending
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_42898 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.76.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...7af577e2: behind); later builds of the same history include it (brave-core#27018)

Members and their history

Issue

brave-browser#42898 [Zcash] Implement spending of shielded inputs

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:shielded, body:shielded

priority/P3 QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Implement spending of shielded Orchard inputs Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No response_

Timeline (7 of 10 events)
  1. 2024-12-13 20:16 Label added OS/Desktop by cypt4
  2. 2024-12-13 20:16 Label added priority/P3 by cypt4
  3. 2024-12-16 21:17 Referenced by brave-core#27018 by cypt4
  4. 2025-01-22 22:39 Closed completed brave-core#27018 by cypt4
  5. 2025-01-22 22:39 Milestone set 1.76.x - Nightly by brave-builds
  6. 2025-01-28 13:09 Label added QA/No by cypt4
  7. 2025-01-28 13:09 Label added release-notes/exclude by cypt4
Pull request

brave-core#27018 [ZCash] Implement Zcash Orchard inputs spending

State: merged 2025-01-22 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash, title:orchard, body:zcashshieldsyncservice

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/42898 Sec review: [GitHub link omitted] Implements basic sync process for the Orchard protocol. Entry point for the sync process is the per-account ZCashShieldSyncService class. Sync process includes: 1) Verifying chain state. In some cases chain reorg may happen so we need to check whether latest scanned block hash hasn't been changed. Otherwise we need to clean OrchardStorage to remove notes, nullifiers and…

Timeline (6 of 10 events)
  1. 2024-12-30 21:45 Ready for review by cypt4
  2. 2025-01-15 16:43 Referenced by brave-browser#43312 by cypt4
  3. 2025-01-15 20:36 Referenced by brave-core#27255 by cypt4
  4. 2025-01-22 22:39 Merged master by cypt4
  5. 2025-01-22 22:39 Closed by cypt4
  6. 2025-01-22 22:39 Milestone set 1.76.x - Nightly by github-actions