Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Two ZCash accounts get created on buy screen

In a Release build Bug Addresses, accounts & memos

Lead item brave-browser#42788 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#26954 merged 2024-12-12 into master by Douglashdaniel
    fix(wallet): Prevent Double Account Creation on Buy Screen
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...059a4374: behind); later builds of the same history include it (brave-core#26954)

Members and their history

Issue

brave-browser#42788 [ZCash] Two ZCash accounts get created on buy screen

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/zcash

Description When you are prompt to create a ZCash account on the new Buy screen. There are some instances where 2 accounts get created. Steps to reproduce 1. Create a brand new wallet and navigate to the Buy screen 2. Select ZCash as the asset to buy, when prompt to create an account click Cancel 3. Re-select ZCash as the asset to buy, when prompt to create an account click Create 4. You will now have 2 ZCash accounts. Actual result see…

Timeline (11 of 15 events)
  1. 2024-12-10 15:32 Label added OS/Desktop by Douglashdaniel
  2. 2024-12-10 15:32 Label added QA/Yes by Douglashdaniel
  3. 2024-12-10 15:32 Label added release-notes/exclude by Douglashdaniel
  4. 2024-12-10 15:36 Referenced by brave-core#26954 by Douglashdaniel
  5. 2024-12-11 10:04 Referenced by brave-browser#42081 by srirambv
  6. 2024-12-12 16:03 Closed completed brave-core#26954 by Douglashdaniel
  7. 2024-12-12 16:04 Milestone set 1.75.x - Nightly by brave-builds
  8. 2024-12-16 18:55 Referenced by brave-core#26997 by kjozwiak
  9. 2024-12-16 18:57 Milestone removed 1.75.x - Nightly by brave-builds
  10. 2024-12-16 18:57 Milestone set 1.74.x - Beta by brave-builds
  11. 2024-12-20 06:39 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#26954 fix(wallet): Prevent Double Account Creation on Buy Screen

State: merged 2024-12-12 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet

Description Fixes a bug where 2 ZCash accounts were being created when prompt to create an account on the Buy screen. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits…

Timeline (6 of 8 events)
  1. 2024-12-10 16:30 Referenced by brave-core#26935 by kjozwiak
  2. 2024-12-12 16:03 Merged master by Douglashdaniel
  3. 2024-12-12 16:03 Closed by Douglashdaniel
  4. 2024-12-12 16:04 Milestone set 1.75.x - Nightly by github-actions
  5. 2024-12-12 16:18 Referenced by brave-core#26997 by brave-builds
  6. 2024-12-20 06:39 Referenced by brave-browser#42788 by srirambv
Uplift PR → 1.74.x

brave-core#26997 fix(wallet): Prevent Double Account Creation on Buy Screen (uplift to 1.74.x)

State: merged 2024-12-16 · created · closed · updated · discovered via mentions:brave/brave-browser#42788, mentions:brave/brave-core#26954

CI/storybook-url feature/web3/wallet

Uplift of #26954 Resolves https://github.com/brave/brave-browser/issues/42788 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2024-12-12 16:18 Milestone set 1.74.x - Beta by brave-builds
  2. 2024-12-16 18:57 Merged 1.74.x by kjozwiak
  3. 2024-12-16 18:57 Closed by kjozwiak

Also mentioned by (not linked as fixes): brave-browser#42081