Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove all uses of `CHECK(false)`

In a Release build Issue General Zcash support

Lead item brave-browser#42331 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26602 merged 2024-11-18 into master by cdesouza-chromium
    [CodeHealth] Remove `CHECK(false)` uses
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...713f6cd6: behind); later builds of the same history include it (brave-core#26602)

Members and their history

Issue

brave-browser#42331 Remove all uses of `CHECK(false)`

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26602

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Any use of CHECK(false) is wrong, and must be corrected following the guidelines in https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/checks.md.

Timeline (6 of 9 events)
  1. 2024-11-17 19:57 Label added OS/Desktop by cdesouza-chromium
  2. 2024-11-17 19:57 Label added QA/No by cdesouza-chromium
  3. 2024-11-17 19:57 Label added release-notes/exclude by cdesouza-chromium
  4. 2024-11-17 19:59 Referenced by brave-core#26602 by cdesouza-chromium
  5. 2024-11-18 16:13 Closed completed brave-core#26602 by cdesouza-chromium
  6. 2024-11-18 16:13 Milestone set 1.75.x - Nightly by brave-builds
Pull request

brave-core#26602 [CodeHealth] Remove `CHECK(false)` uses

State: merged 2024-11-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core

All uses of CHECK(false) are incorrect and should be either a NOTREACHED, LOG(ERROR), or higher CHECK that removed the enclosing conditional code path. Resolves https://github.com/brave/brave-browser/issues/42331 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ]…

Timeline (3 of 5 events)
  1. 2024-11-18 16:13 Merged master by cdesouza-chromium
  2. 2024-11-18 16:13 Closed by cdesouza-chromium
  3. 2024-11-18 16:13 Milestone set 1.75.x - Nightly by github-actions