Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Disable `Switch to shielded account` option when its enabled for one Zcash account

In a Release build Bug Shielded (Orchard) support

Lead item brave-browser#42294 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#26564 merged 2024-11-15 into master by Douglashdaniel
    fix(wallet): Disable Shield Button if an Account is already Shielded
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...3484d231: behind); later builds of the same history include it (brave-core#26564)

Members and their history

Issue

brave-browser#42294 Disable `Switch to shielded account` option when its enabled for one Zcash account

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash, title:shielded, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop

Description Disable Switch to shielded account option when its enabled for one ZCash account Steps to reproduce 1. Create 2 ZCash account 2. Go to Accounts 3. Click on menu for ZCash account 4. Click on Switch to shielded account 5. Confirmation modal is shown and adds Shielded tag to the account 6. Click on more menu for second ZCash account 7. Shows Switch to shielded account option 8. Clicking on it shows confirmation modal but accepting it doesn't make the account…

Timeline (8 of 10 events)
  1. 2024-11-14 10:02 Label added OS/Desktop by srirambv
  2. 2024-11-14 10:02 Label added QA/Yes by srirambv
  3. 2024-11-14 10:02 Label added release-notes/exclude by srirambv
  4. 2024-11-14 10:07 Referenced by brave-browser#41780 by srirambv
  5. 2024-11-14 23:04 Referenced by brave-core#26564 by Douglashdaniel
  6. 2024-11-15 16:05 Closed completed brave-core#26564 by Douglashdaniel
  7. 2024-11-15 16:05 Milestone set 1.75.x - Nightly by brave-builds
  8. 2024-12-19 10:48 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#26564 fix(wallet): Disable Shield Button if an Account is already Shielded

State: merged 2024-11-15 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr · matched title:shielded, body:zcash

CI/storybook-url feature/web3/wallet

Description Disables the Switch to Shielded Account button if an Account in the keyring has already been Shielded Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits…

Timeline (4 of 6 events)
  1. 2024-11-15 16:05 Merged master by Douglashdaniel
  2. 2024-11-15 16:05 Closed by Douglashdaniel
  3. 2024-11-15 16:05 Milestone set 1.75.x - Nightly by github-actions
  4. 2024-12-19 10:48 Referenced by brave-browser#42294 by srirambv

Also mentioned by (not linked as fixes): brave-browser#41780