Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix the known cases of use-after-move in the codebase

In a Release build Issue General Zcash support

Lead item brave-browser#42264 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26526 merged 2024-11-13 into master by cdesouza-chromium
    [CodeHealth] Fix various use-after-move violations
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...6da3839d: behind); later builds of the same history include it (brave-core#26526)

Members and their history

Issue

brave-browser#42264 Fix the known cases of use-after-move in the codebase

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26526

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Every now and then clang-tidy warns against a few known cases in our codebase of use-after-move. Some of these are potential crashes. We should go about fixing those.

Timeline (7 of 10 events)
  1. 2024-11-13 14:15 Referenced by brave-core#26526 by cdesouza-chromium
  2. 2024-11-13 23:59 Closed completed brave-core#26526 by cdesouza-chromium
  3. 2024-11-13 23:59 Closed completed by cdesouza-chromium
  4. 2024-11-13 23:59 Milestone set 1.75.x - Nightly by brave-builds
  5. 2024-11-15 08:02 Label added QA/No by cdesouza-chromium
  6. 2024-11-15 08:02 Label added release-notes/exclude by cdesouza-chromium
  7. 2024-12-04 11:53 Label added OS/Desktop by cdesouza-chromium
Pull request

brave-core#26526 [CodeHealth] Fix various use-after-move violations

State: merged 2024-11-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core

This change fixes several instances where use-after-move is possible in our codebase. For potential use-after-move cases involving OnceCallback instances, those are potential crahes in the application. Additionally, this PR corrects the use of moved-from std containers. It is valid to use a moved-from container, but it is expected that the container is cleared before being used again. Resolves https://github.com/brave/brave-browser/issues/42264 Resolves Submitter Checklist:…

Timeline (3 of 5 events)
  1. 2024-11-13 23:59 Merged master by cdesouza-chromium
  2. 2024-11-13 23:59 Closed by cdesouza-chromium
  3. 2024-11-13 23:59 Milestone set 1.75.x - Nightly by github-actions