Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

Fix NOTREACHED_IN_MIGRATION for wallet

In a Release build Issue General Zcash support

Lead item brave-browser#42203 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26380 merged 2024-11-15 into master by supermassive
    Fix NOTREACHED_IN_MIGRATION for wallet
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...e4de839e: behind); later builds of the same history include it (brave-core#26380)

Members and their history

Issue

brave-browser#42203 Fix NOTREACHED_IN_MIGRATION for wallet

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26380

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Fix NOTREACHED_IN_MIGRATION for wallet

Timeline (6 of 9 events)
  1. 2024-11-11 09:56 Referenced by brave-core#26380 by supermassive
  2. 2024-11-15 04:57 Closed completed brave-core#26380 by supermassive
  3. 2024-11-15 04:57 Milestone set 1.75.x - Nightly by brave-builds
  4. 2024-11-22 11:11 Label added QA/No by supermassive
  5. 2024-11-22 11:11 Label added release-notes/exclude by supermassive
  6. 2024-11-22 11:11 Label added OS/Desktop by supermassive
Pull request

brave-core#26380 Fix NOTREACHED_IN_MIGRATION for wallet

State: merged 2024-11-15 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/42203 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (4 of 7 events)
  1. 2024-11-15 04:57 Merged master by supermassive
  2. 2024-11-15 04:57 Closed by supermassive
  3. 2024-11-15 04:57 Milestone set 1.75.x - Nightly by github-actions
  4. 2024-11-16 01:24 Referenced by brave-core#26598 by yrliou