Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Revert the latest wallets SAFE_BUFFERS pr, as it is specialising `base::span` in incompatible ways

In a Release build Issue General Zcash support

Lead item brave-browser#42124 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26392 merged 2024-11-06 into master by cdesouza-chromium
    Revert "Fix UNSAFE_TODO for wallet (#26253)"
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...c7289659: behind); later builds of the same history include it (brave-core#26392)

Members and their history

Issue

brave-browser#42124 Revert the latest wallets SAFE_BUFFERS pr, as it is specialising `base::span` in incompatible ways

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26392

QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description This PR has introduced something that would be Undefined Behaviour if we were using std::span, and it shouldn't have been done. This has has broken cr132: [code] This PR also had outstanding comments, and shouldn't have been merged in the first place.

Timeline (6 of 10 events)
  1. 2024-11-06 16:13 Referenced by brave-core#26392 by cdesouza-chromium
  2. 2024-11-06 17:59 Closed completed brave-core#26392 by bridiver
  3. 2024-11-06 17:59 Milestone set 1.73.x - Nightly by brave-builds
  4. 2024-11-11 23:46 Label added QA/No by bridiver
  5. 2024-11-11 23:46 Label added release-notes/exclude by bridiver
  6. 2024-11-11 23:46 Label added OS/Desktop by bridiver
Pull request

brave-core#26392 Revert "Fix UNSAFE_TODO for wallet (#26253)"

State: merged 2024-11-06 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

This reverts commit e8405573b0a676c3c2175fdaa9f4a7719ea6b085. The original PR introduces a specialisation to base::internal that is not allowed, and would be Undefined Behaviour with std::span. This has broken cr132. Resolves https://github.com/brave/brave-browser/issues/42124 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used…

Timeline (5 of 10 events)
  1. 2024-11-06 17:59 Merged master by bridiver
  2. 2024-11-06 17:59 Closed by bridiver
  3. 2024-11-06 17:59 Milestone set 1.73.x - Nightly by github-actions
  4. 2024-11-06 18:12 Milestone removed 1.73.x - Nightly by bsclifton
  5. 2024-11-06 18:12 Milestone set 1.74.x - Nightly by bsclifton