Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio

In a Release build Bug Balances, pricing & display

Lead item brave-browser#42083 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26419 merged 2024-11-08 into master by Douglashdaniel
    fix(wallet): BTC and ZEC Buy Quotes from Route
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...e6eceb00: behind); later builds of the same history include it (brave-core#26419)

Members and their history

Issue

brave-browser#42083 Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio

State: closed (completed) · created · closed · updated · discovered via search:zcash, search:zec · matched title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop front-end-change

Description Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio Steps to reproduce 1. Create Bitcoin account 2. Select Buy from BTC token menu in portfolio 3. Buy screen shows but doesn't show message for providers 4. Repeat the same steps for ZCash, same result Actual result [image] Expected result Do not show Buy option for BTC/ZCash if not supported Reproduces how often Easily reproduced Brave version (brave://version info)…

Timeline (11 of 14 events)
  1. 2024-11-05 09:50 Label added OS/Desktop by srirambv
  2. 2024-11-05 09:50 Label added QA/Yes by srirambv
  3. 2024-11-05 09:50 Label added release-notes/exclude by srirambv
  4. 2024-11-06 22:04 Referenced by brave-core#26419 by Douglashdaniel
  5. 2024-11-08 14:53 Closed completed brave-core#26419 by Douglashdaniel
  6. 2024-11-08 14:53 Milestone set 1.75.x - Nightly by brave-builds
  7. 2024-11-11 06:08 Referenced by brave-core#26455 by kjozwiak
  8. 2024-11-11 18:40 Milestone removed 1.75.x - Nightly by brave-builds
  9. 2024-11-11 18:40 Milestone set 1.74.x - Beta by brave-builds
  10. 2024-11-18 07:06 Referenced by brave-browser#38985 by srirambv
  11. 2024-11-18 07:35 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#26419 fix(wallet): BTC and ZEC Buy Quotes from Route

State: merged 2024-11-08 · created · closed · updated · discovered via search:zec is:pr · matched title:zec, body:zec

CI/storybook-url feature/web3/wallet

Description Fixes a bug where Buy quotes were not being fetched for BTC and ZEC when clicking buy from the Portfolio page. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup"…

Timeline (5 of 7 events)
  1. 2024-11-08 14:53 Merged master by Douglashdaniel
  2. 2024-11-08 14:53 Closed by Douglashdaniel
  3. 2024-11-08 14:53 Milestone set 1.75.x - Nightly by github-actions
  4. 2024-11-08 16:10 Referenced by brave-core#26455 by brave-builds
  5. 2024-11-18 07:35 Referenced by brave-browser#42083 by srirambv
Uplift PR → 1.74.x

brave-core#26455 fix(wallet): BTC and ZEC Buy Quotes from Route (uplift to 1.74.x)

State: merged 2024-11-11 · created · closed · updated · discovered via search:zec is:pr · matched title:zec

CI/storybook-url feature/web3/wallet

Uplift of #26419 Resolves https://github.com/brave/brave-browser/issues/42083 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2024-11-08 16:10 Milestone set 1.74.x - Beta by brave-builds
  2. 2024-11-11 18:39 Merged 1.74.x by kjozwiak
  3. 2024-11-11 18:39 Closed by kjozwiak