Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Buy option is shown and loads empty account details for tokens that doesn't have account created

In a Release build Bug Addresses, accounts & memos

Lead item brave-browser#42081 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#26850 merged 2024-12-09 into master by Douglashdaniel
    fix(wallet): Allow Creating Wallet on Buy Screen
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...195b7d5f: behind); later builds of the same history include it (brave-core#26850)

Members and their history

Issue

brave-browser#42081 [ZCash] Buy option is shown and loads empty account details for tokens that doesn't have account created

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Buy option is shown and loads empty account details for tokens that doesn't have account created Steps to reproduce 1. Create new wallet or restore one 2. Select Zcash token in portfolio 3. Click on menu and click on Buy 4. Shows Zcash in Buy screen but no account is shown Actual result [GitHub link omitted] Expected result Should not show Buy option on tokens where account is not created Reproduces how often Easily reproduced Brave version (brave://version…

Timeline (10 of 14 events)
  1. 2024-11-05 09:20 Label added OS/Desktop by srirambv
  2. 2024-11-05 09:20 Label added QA/Yes by srirambv
  3. 2024-11-05 09:20 Label added release-notes/exclude by srirambv
  4. 2024-11-18 07:06 Referenced by brave-browser#38985 by srirambv
  5. 2024-12-04 02:15 Referenced by brave-core#26850 by Douglashdaniel
  6. 2024-12-09 18:56 Closed completed brave-core#26850 by Douglashdaniel
  7. 2024-12-09 18:56 Milestone set 1.75.x - Nightly by brave-builds
  8. 2024-12-10 16:24 Milestone removed 1.75.x - Nightly by brave-builds
  9. 2024-12-10 16:24 Milestone set 1.74.x - Beta by brave-builds
  10. 2024-12-11 10:05 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#26850 fix(wallet): Allow Creating Wallet on Buy Screen

State: merged 2024-12-09 · created · closed · updated · discovered via search:zcash is:pr, search:zec is:pr · matched body:zec

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Description Fixes a bug where you were not able to create an Account on the new Buy screen. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that…

Timeline (5 of 8 events)
  1. 2024-12-09 18:56 Merged master by Douglashdaniel
  2. 2024-12-09 18:56 Closed by Douglashdaniel
  3. 2024-12-09 18:56 Milestone set 1.75.x - Nightly by github-actions
  4. 2024-12-09 18:59 Referenced by brave-core#26935 by brave-builds
  5. 2024-12-10 15:32 Referenced by brave-browser#42788 by Douglashdaniel
Uplift PR → 1.74.x

brave-core#26935 fix(wallet): Allow Creating Wallet on Buy Screen (uplift to 1.74.x)

State: merged 2024-12-10 · created · closed · updated · discovered via mentions:brave/brave-core#26850, mentions:brave/brave-core#26954

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of #26850 Resolves https://github.com/brave/brave-browser/issues/42687 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 6 events)
  1. 2024-12-09 20:35 Milestone set 1.74.x - Beta by Douglashdaniel
  2. 2024-12-10 16:23 Merged 1.74.x by kjozwiak
  3. 2024-12-10 16:23 Closed by kjozwiak