Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Add orchard address check to the ValidateZCashAddress

In a Release build Feature Security & hardening

Lead item brave-browser#42064 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Enhancement.

Implementation

  • brave-core#26370 merged 2024-11-07 into master by cypt4
    Extend ValidateZCashAddress to return whether address is shielded
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_42064_1 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...0d88fd90: behind); later builds of the same history include it (brave-core#26370)

Members and their history

Issue

brave-browser#42064 [Zcash] Add orchard address check to the ValidateZCashAddress

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:orchard

QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Allow differentiation between different address types in ValidateZCashAddress Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No response_

Timeline (6 of 9 events)
  1. 2024-11-04 11:11 Label added OS/Desktop by cypt4
  2. 2024-11-05 14:10 Referenced by brave-core#26370 by cypt4
  3. 2024-11-07 15:07 Closed completed brave-core#26370 by cypt4
  4. 2024-11-07 15:08 Milestone set 1.75.x - Nightly by brave-builds
  5. 2024-11-11 12:33 Label added QA/No by cypt4
  6. 2024-11-11 12:33 Label added release-notes/exclude by cypt4
Pull request

brave-core#26370 Extend ValidateZCashAddress to return whether address is shielded

State: merged 2024-11-07 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:shielded is:pr · matched title:shielded

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/42064 Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened…

Timeline (3 of 6 events)
  1. 2024-11-07 15:07 Merged master by cypt4
  2. 2024-11-07 15:07 Closed by cypt4
  3. 2024-11-07 15:08 Milestone set 1.75.x - Nightly by github-actions