Lead item brave-browser#42016 · opened by cdesouza-chromium · last source update
IssueClosed (completed)
Linked fixMerged
Code in builds9 of 9 current builds
Release notesNot listed
QANot QA-tested
Issue state
Closed (completed)
Closed .
Implementation
brave-core#26332merged 2024-11-01 into master by cdesouza-chromium [DanglingPtr][wallet] Prefer non-nullable states pt.1 Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
brave-core#26343merged 2024-11-05 into master by cdesouza-chromium [DanglingPtr][wallet] Prefer non-nullable states pt.2 Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
Release notes
No platform changelog lists this item.
Validation
Not QA-tested (QA/No).
No QA pass labels.
QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.
Target
1.74.x - Release
For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.
Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.
Platform
Release
Beta
Nightly
Desktop
Included1.97.59in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Included1.98.47in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Included1.100.5in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Android
Included1.97.57in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Included1.98.52in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Included1.100.5in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
iOS
Included1.96.62in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Included1.99.44in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Included1.100.7in v1.96.61 (GitHub compare v1.96.61...6d0ffe2f: behind); later builds of the same history include it (brave-core#26332)
Description There are a few cases of dangling pointers in wallets that must be sorted. But we should first communicate better optional references, by documenting necessary references as raw references, rather than pointers.
This change touches several parts of wallets where we are passing pointers around that are expected to be in a valid state, and remain so for the duration of the lifetime of the object receiving them. Historically, chromium had a guideline that required passing non-owning references as raw pointers. This has changed for a while now, and there are even supporting types like raw_ref for it. Raw pointers should be used for cases where flexibility is required about the lifetime…
This change touches several parts of wallets where we are passing pointers around that are expected to be in a valid state, and remain so for the duration of the lifetime of the object receiving them. Historically, chromium had a guideline that required passing non-owning references as raw pointers. This has changed for a while now, and there are even supporting types like raw_ref for it. Raw pointers should be used for cases where flexibility is required about the lifetime…