Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Tag all failing dangling reports as `DanglingUntriaged` for Linux

In a Release build Issue General Zcash support

Lead item brave-browser#41896 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26244 merged 2024-10-28 into master by cdesouza-chromium
    [DanglingPtr][linux] Dangling violations as untriaged
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...1a3eb65e: behind); later builds of the same history include it (brave-core#26244)

Members and their history

Issue

brave-browser#41896 Tag all failing dangling reports as `DanglingUntriaged` for Linux

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26244

OS/Linux QA/No dev-concern release-notes/exclude feature/web3/wallet feature/web3/wallet/core

Description As we work to enable dangling pointer checks with BackupRefPtr, we should tag all violations as DanglingUntriaged, so each team can collaborate in correcting those too.

Timeline (6 of 9 events)
  1. 2024-10-25 17:49 Label added OS/Linux by cdesouza-chromium
  2. 2024-10-25 17:49 Label added QA/No by cdesouza-chromium
  3. 2024-10-25 17:49 Label added release-notes/exclude by cdesouza-chromium
  4. 2024-10-25 17:53 Referenced by brave-core#26244 by cdesouza-chromium
  5. 2024-10-28 16:02 Closed completed brave-core#26244 by cdesouza-chromium
  6. 2024-10-28 16:03 Milestone set 1.73.x - Nightly by brave-builds
Pull request

brave-core#26244 [DanglingPtr][linux] Dangling violations as untriaged

State: merged 2024-10-28 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/run-network-audit feature/web3/wallet feature/web3/wallet/core puLL-Merge

This PR marks all the dangling pointers causing test crahses on linux as DanglingUntriaged. This is the first step to gradually permit switching on dangling pointer check on CI. This change does not include upstream patches, that may be required depending on how difficult it becomes to fix those. This is a mechanical change that should have no function effect. Resolves https://github.com/brave/brave-browser/issues/41896 Resolves Submitter Checklist: - [ ] I confirm that no…

Timeline (5 of 9 events)
  1. 2024-10-28 16:02 Merged master by cdesouza-chromium
  2. 2024-10-28 16:02 Closed by cdesouza-chromium
  3. 2024-10-28 16:03 Milestone set 1.73.x - Nightly by github-actions
  4. 2024-11-06 18:14 Milestone removed 1.73.x - Nightly by bsclifton
  5. 2024-11-06 18:14 Milestone set 1.74.x - Nightly by bsclifton