Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Build out Shield ZCash Account Modal

In release notes Feature Shielded (Orchard) support

Lead item brave-browser#41780 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26214 merged 2024-10-30 into master by Douglashdaniel
    feat(wallet): Shield ZCash Account Modal
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.74.48: “Implemented ZCash Shielded account modal. (#41780)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...62e8e1f3: behind); later builds of the same history include it (brave-core#26214)

Members and their history

Issue

brave-browser#41780 [ZCash] Build out Shield ZCash Account Modal

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:shielded wallet, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

QA Pass-Win64 QA/Yes release-notes/include feature-request feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/core feature/web3/wallet/zcash

Platforms all, Windows, macOS, Linux Description We need to build out and wire up the new Shield ZCash Account modal. Figma Design: https://www.figma.com/design/muVcmcu4RFNu0LkXe9VRDl/Wallet-2.0?node-id=18149-180128&node-type=frame&t=VCgBU4zVzCjUX4oA-0 [image] [image]

Timeline (8 of 13 events)
  1. 2024-10-22 04:40 Label added OS/Desktop by Douglashdaniel
  2. 2024-10-22 04:40 Label added QA/Yes by Douglashdaniel
  3. 2024-10-22 04:40 Label added release-notes/include by Douglashdaniel
  4. 2024-10-24 21:56 Referenced by brave-core#26214 by Douglashdaniel
  5. 2024-10-30 22:18 Closed completed brave-core#26214 by Douglashdaniel
  6. 2024-10-30 22:18 Milestone set 1.73.x - Nightly by brave-builds
  7. 2024-11-14 10:07 Label added QA Pass-Win64 by srirambv
  8. 2025-01-14 13:45 Referenced by brave-browser#43284 by LaurenWags
Pull request

brave-core#26214 feat(wallet): Shield ZCash Account Modal

State: merged 2024-10-30 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Description Introduces the ability to Shield a ZCash Account on the Accounts page. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that history is a…

Timeline (6 of 12 events)
  1. 2024-10-30 22:18 Merged master by Douglashdaniel
  2. 2024-10-30 22:18 Closed by Douglashdaniel
  3. 2024-10-30 22:18 Milestone set 1.73.x - Nightly by github-actions
  4. 2024-11-06 18:14 Milestone removed 1.73.x - Nightly by bsclifton
  5. 2024-11-06 18:14 Milestone set 1.74.x - Nightly by bsclifton
  6. 2024-11-14 10:07 Referenced by brave-browser#41780 by srirambv