Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Adjust create wallet account ui

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#41573 · opened by supermassive · last source update

Part of Support BTC Ledger hardware accounts (brave-browser#38447).

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#25948 merged 2024-10-16 into master by supermassive
    Adjust create wallet account ui
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...5e19b6a5: behind); later builds of the same history include it (brave-core#25948)

Members and their history

Issue

brave-browser#41573 Adjust create wallet account ui

State: closed (completed) · created · closed · updated · discovered via search:zec · matched body:zec

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/bitcoin feature/web3/wallet/core

For FIL, BTC and ZEC should see separate items on first screen when creating/importing/hw accounts [image]

Timeline (8 of 12 events)
  1. 2024-10-11 10:00 Referenced by brave-core#25948 by supermassive
  2. 2024-10-16 02:27 Closed completed brave-core#25948 by supermassive
  3. 2024-10-16 02:28 Milestone set 1.73.x - Nightly by brave-builds
  4. 2024-10-21 03:50 Label added QA/Yes by supermassive
  5. 2024-10-21 03:50 Label added release-notes/exclude by supermassive
  6. 2024-10-21 03:50 Label added OS/Android by supermassive
  7. 2024-10-21 03:50 Label added OS/Desktop by supermassive
  8. 2024-11-13 16:49 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#25948 Adjust create wallet account ui

State: merged 2024-10-16 · created · closed · updated · discovered via search:zcash is:pr, search:zec is:pr · matched body:zec

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/41573 Adjusted Create/Import/Create-Hardware Account UI so test networks accounts are shown as separate items when corresponding network is enabled. This is for FIL, BTC and ZEC. [image] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR…

Timeline (7 of 11 events)
  1. 2024-10-11 10:01 Ready for review by supermassive
  2. 2024-10-16 02:27 Merged master by supermassive
  3. 2024-10-16 02:27 Closed by supermassive
  4. 2024-10-16 02:27 Milestone set 1.73.x - Nightly by github-actions
  5. 2024-11-06 18:13 Milestone removed 1.73.x - Nightly by bsclifton
  6. 2024-11-06 18:13 Milestone set 1.74.x - Nightly by bsclifton
  7. 2024-11-13 16:49 Referenced by brave-browser#41573 by srirambv