Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Const-value arguments mistakenly used instead of const-refs.

In a Release build Issue General Zcash support

Lead item brave-browser#41358 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#25797 merged 2024-10-04 into master by cdesouza-chromium
    [CodeHealth] Avoid accidental const-copies - Part II
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.73.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...ddfe9004: behind); later builds of the same history include it (brave-core#25797)

Members and their history

Issue

brave-browser#41358 Const-value arguments mistakenly used instead of const-refs.

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#25797

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Of particular concern when passing vectors and strings, as unintended copies occur under the covers. Poking around with an overzealous grep for const std::[^ ][^&] \w\w[,)] includes places where we've written const T but meant const T&.

Timeline (8 of 11 events)
  1. 2024-10-02 14:24 Label added QA/No by cdesouza-chromium
  2. 2024-10-02 14:24 Label added release-notes/exclude by cdesouza-chromium
  3. 2024-10-02 14:24 Label added OS/Desktop by cdesouza-chromium
  4. 2024-10-02 14:25 Referenced by brave-core#25774 by cdesouza-chromium
  5. 2024-10-03 14:18 Closed completed brave-core#25774 by cdesouza-chromium
  6. 2024-10-03 14:19 Milestone set 1.72.x - Nightly by brave-builds
  7. 2024-10-03 15:55 Referenced by brave-core#25797 by cdesouza-chromium
  8. 2024-10-06 20:23 Referenced by brave-core#25835 by cdesouza-chromium
Pull request

brave-core#25797 [CodeHealth] Avoid accidental const-copies - Part II

State: merged 2024-10-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

This is of concern when passing vectors and strings, as unintended (and often expensive) copies occur under the covers. -- Make non-const and move in callee where appropriate. -- Convert to string_view where appropriate. -- Avoid stray const in a few places Additionally, an unnecessary JSON util parsing function was removed from a test. Resolves https://github.com/brave/brave-browser/issues/41358 Submitter Checklist: - [x] I confirm that no security/privacy review is needed…

Timeline (3 of 6 events)
  1. 2024-10-04 13:57 Merged master by cdesouza-chromium
  2. 2024-10-04 13:57 Closed by cdesouza-chromium
  3. 2024-10-04 13:57 Milestone set 1.72.x - Nightly by github-actions