Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Refactor wallet's hardware signing code

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#41121 · opened by supermassive · last source update

Part of Support BTC Ledger hardware accounts (brave-browser#38447).

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#25386 merged 2024-09-18 into master by supermassive
    Refactor signing code
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.73.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...2a4e3876: behind); later builds of the same history include it (brave-core#25386)

Members and their history

Issue

brave-browser#41121 Refactor wallet's hardware signing code

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#25386

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/hardwaresupport

Timeline (8 of 11 events)
  1. 2024-09-18 08:52 Referenced by brave-browser#38447 by supermassive
  2. 2024-09-18 08:52 Label added QA/Yes by supermassive
  3. 2024-09-18 08:52 Label added release-notes/exclude by supermassive
  4. 2024-09-18 08:52 Label added OS/Desktop by supermassive
  5. 2024-09-18 08:56 Referenced by brave-core#25386 by supermassive
  6. 2024-09-18 08:57 Closed completed brave-core#25386 by supermassive
  7. 2024-09-18 08:57 Milestone set 1.72.x - Nightly by brave-builds
  8. 2024-11-06 12:01 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#25386 Refactor signing code

State: merged 2024-09-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/41121 Refactored parts of core/ui responsible of signing transactions/messages: - Merged SignTransactionRequest and SignAllTransactionsRequest into SignSolTransactionsRequest. This is SOL only. Both dApp signTransaction and signAllTransactions are still there but internally there is only one implementation. - Refactored SimulationService to run SOL simulations separately for SignSolTransactionsRequest and…

Timeline (5 of 11 events)
  1. 2024-09-12 02:10 Ready for review by supermassive
  2. 2024-09-18 08:57 Merged master by supermassive
  3. 2024-09-18 08:57 Closed by supermassive
  4. 2024-09-18 08:57 Milestone set 1.72.x - Nightly by github-actions
  5. 2024-11-06 12:01 Referenced by brave-browser#41121 by srirambv

Also mentioned by (not linked as fixes): brave-browser#38447