Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Balance resolution problems

In release notes Bug Balances, pricing & display

Lead item brave-browser#40635 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#25296 merged 2024-08-23 into master by cypt4
    Fix ZCash balances
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_40635 (weaker evidence; titles share a keyword)

Uplifts to release branches

Release notes

  • Desktop 1.69.160: “Fixed ZCash balance resolution issue. (#40635)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release #2

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...3cf6dbf2: behind); later builds of the same history include it (brave-core#25296)

Members and their history

Issue

brave-browser#40635 [ZCash] Balance resolution problems

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash, body:zcash

bug QA Pass-Win64 priority/P2 QA/Yes release-notes/include feature/web3/wallet OS/Desktop

Description There could be balance resolution problems on accounts which have used receiver addresses with 0 utxos. Steps to reproduce 1. Create zcash account 2. Receive funds, so account has one incoming transaction from creation 3. Send half of funds to another account. 4. Receive funds again. Actual result Balance will be 0 Expected result Balance should be actual Reproduces how often Easily reproduced Desktop Brave version (brave://version info) 1.69 Android device -…

Timeline (17 of 20 events)
  1. 2024-08-23 17:57 Label added OS/Android by cypt4
  2. 2024-08-23 17:57 Label added OS/Desktop by cypt4
  3. 2024-08-23 17:57 Label added priority/P2 by cypt4
  4. 2024-08-23 18:26 Referenced by brave-core#25296 by cypt4
  5. 2024-08-23 20:24 Closed completed brave-core#25296 by cypt4
  6. 2024-08-23 20:24 Closed completed by cypt4
  7. 2024-08-23 20:24 Milestone set 1.71.x - Nightly by brave-builds
  8. 2024-08-23 20:31 Referenced by brave-core#25303 by brave-builds
  9. 2024-08-23 20:31 Referenced by brave-core#25304 by brave-builds
  10. 2024-08-26 02:43 Label added QA/Yes by kjozwiak
  11. 2024-08-26 15:27 Milestone removed 1.71.x - Nightly by brave-builds
  12. 2024-08-26 15:27 Milestone set 1.70.x - Beta by brave-builds
  13. 2024-08-26 15:27 Milestone removed 1.70.x - Beta by brave-builds
  14. 2024-08-26 15:27 Milestone set 1.69.x - Release #2 by brave-builds
  15. 2024-08-26 15:27 Label added release-notes/include by kjozwiak
  16. 2024-08-27 11:07 Label added QA Pass-Win64 by srirambv
  17. 2024-08-29 15:48 Referenced by brave-browser#40766 by LaurenWags
Pull request

brave-core#25296 Fix ZCash balances

State: merged 2024-08-23 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

Resolves https://github.com/brave/brave-browser/issues/40635 Utxos response can have empty body - this shouldn't be treated as an error Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup"…

Timeline (5 of 5 events)
  1. 2024-08-23 20:24 Merged master by cypt4
  2. 2024-08-23 20:24 Closed by cypt4
  3. 2024-08-23 20:24 Milestone set 1.71.x - Nightly by github-actions
  4. 2024-08-23 20:31 Referenced by brave-core#25303 by brave-builds
  5. 2024-08-23 20:31 Referenced by brave-core#25304 by brave-builds
Uplift PR → 1.69.x

brave-core#25304 Fix ZCash balances (uplift to 1.69.x)

State: merged 2024-08-26 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

Uplift of #25296 Resolves https://github.com/brave/brave-browser/issues/40635 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 3 events)
  1. 2024-08-23 20:31 Milestone set 1.69.x - Release #2 by brave-builds
  2. 2024-08-26 15:27 Merged 1.69.x by kjozwiak
  3. 2024-08-26 15:27 Closed by kjozwiak
Uplift PR → 1.70.x

brave-core#25303 Fix ZCash balances (uplift to 1.70.x)

State: merged 2024-08-26 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

Uplift of #25296 Resolves https://github.com/brave/brave-browser/issues/40635 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 3 events)
  1. 2024-08-23 20:31 Milestone set 1.70.x - Beta by brave-builds
  2. 2024-08-26 15:26 Merged 1.70.x by kjozwiak
  3. 2024-08-26 15:26 Closed by kjozwiak