Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Add basic memo support

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#40602 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#25284 merged 2024-09-13 into master by cypt4
    Add explicit t->s transactions with memo field
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_40602 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.73.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...6b1965ce: behind); later builds of the same history include it (brave-core#25284)

Members and their history

Issue

brave-browser#40602 [ZCash] Add basic memo support

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Add a possibility to send explicit transactions from t->s with provided memo field Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Desktop Brave version (brave://version info) - Android device - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No…

Timeline (8 of 11 events)
  1. 2024-08-22 11:28 Label added OS/Android by cypt4
  2. 2024-08-22 11:28 Label added OS/Desktop by cypt4
  3. 2024-08-22 11:30 Referenced by brave-core#25284 by cypt4
  4. 2024-09-13 15:45 Closed completed brave-core#25284 by cypt4
  5. 2024-09-13 15:45 Closed completed by cypt4
  6. 2024-09-13 15:46 Milestone set 1.72.x - Nightly by brave-builds
  7. 2024-09-16 08:15 Label added QA/No by cypt4
  8. 2024-09-16 08:15 Label added release-notes/exclude by cypt4
Pull request

brave-core#25284 Add explicit t->s transactions with memo field

State: merged 2024-09-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched body:zcashcreateshieldtransactiontask

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/40602 Allows to send from t -> s with adding memo field. ZCashCreateShieldTransactionTask is reused both for shield all and t->s transactions. Extracted tx signing to a separate class - ZCashTransactionCompleteManager. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github…

Timeline (4 of 8 events)
  1. 2024-08-27 17:58 Ready for review by cypt4
  2. 2024-09-13 15:45 Merged master by cypt4
  3. 2024-09-13 15:45 Closed by cypt4
  4. 2024-09-13 15:46 Milestone set 1.72.x - Nightly by github-actions