Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Add shardtree crate

In a Release build Issue Sync, scanning & storage

Lead item brave-browser#40408 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26474 closed without merge into master by cypt4
    [ZCash] Add shardtree + zcash_client_backend crates
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#25092 closed without merge into master by cypt4
    [Zcash] Add shardtree crate
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_40408 (weaker evidence; titles share a keyword)
  • brave-core#26966 merged 2024-12-13 into master by cypt4
    Add shardtree crate
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...d6f3c15e: behind); later builds of the same history include it (brave-core#26966)

Members and their history

Issue

brave-browser#40408 [Zcash] Add shardtree crate

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:shielded

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Shardtree crate is needed for shielded inputs support Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Desktop Brave version (brave://version info) - Android device - Brand/model: - Android version: Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No…

Timeline (10 of 13 events)
  1. 2024-08-12 16:51 Label added OS/Android by cypt4
  2. 2024-08-12 16:51 Label added OS/Desktop by cypt4
  3. 2024-08-12 17:29 Referenced by brave-core#25092 by cypt4
  4. 2024-11-11 14:35 Referenced by brave-core#26474 by cypt4
  5. 2024-12-10 20:03 Referenced by brave-core#26966 by cypt4
  6. 2024-12-13 12:18 Closed completed brave-core#26966 by cypt4
  7. 2024-12-13 12:18 Closed completed by cypt4
  8. 2024-12-13 12:19 Milestone set 1.75.x - Nightly by brave-builds
  9. 2024-12-16 13:51 Label added QA/No by cypt4
  10. 2024-12-16 13:51 Label added release-notes/exclude by cypt4
Pull request

brave-core#26474 [ZCash] Add shardtree + zcash_client_backend crates

State: closed without merge · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash, body:zcash_client_backend

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core chromium-version-mismatch

Resolves https://github.com/brave/brave-browser/issues/40408 Previous pr : https://github.com/brave/brave-core/pull/25092 Audit : [GitHub link omitted] zcash_client_backend audit: [GitHub link omitted] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good…

Timeline (4 of 8 events)
  1. 2024-11-11 20:28 Referenced by brave-core#26477 by cypt4
  2. 2024-11-19 10:37 Ready for review by cypt4
  3. 2024-12-10 20:03 Referenced by brave-core#26966 by cypt4
  4. 2024-12-10 20:10 Closed by cypt4
Pull request

brave-core#25092 [Zcash] Add shardtree crate

State: closed without merge · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash, body:zcash_client_backend

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/40408 Adds shardtree crate + zcash_client_backend part which is used for shard tree seriazation ( [GitHub link omitted] ) Audit : [GitHub link omitted] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a…

Timeline (3 of 6 events)
  1. 2024-11-11 17:20 Closed by cypt4
  2. 2024-11-13 15:43 Referenced by brave-core#26474 by cypt4
  3. 2024-12-10 20:03 Referenced by brave-core#26966 by cypt4
Pull request

brave-core#26966 Add shardtree crate

State: merged 2024-12-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched body:zcash_client_backend

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

// Reopened https://github.com/brave/brave-core/pull/26474 Resolves https://github.com/brave/brave-browser/issues/40408 Previous pr : https://github.com/brave/brave-core/pull/25092 Audit : [GitHub link omitted] zcash_client_backend audit: [GitHub link omitted] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing…

Timeline (6 of 9 events)
  1. 2024-12-10 20:08 Ready for review by cypt4
  2. 2024-12-10 20:10 Referenced by brave-core#26474 by cypt4
  3. 2024-12-11 20:38 Referenced by brave-core#26477 by cypt4
  4. 2024-12-13 12:18 Merged master by cypt4
  5. 2024-12-13 12:18 Closed by cypt4
  6. 2024-12-13 12:18 Milestone set 1.75.x - Nightly by github-actions