Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Implement SafeSign for LiFi bridge transactions (core)

In a Release build Issue Transactions & fees

Lead item brave-browser#39701 · opened by onyb · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24608 merged 2024-07-18 into master by onyb
    feat(wallet): add SafeSign to LiFi bridge transactions
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: onyb · PR authors: onyb, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...8b94752e: behind); later builds of the same history include it (brave-core#24608)

Members and their history

Issue

brave-browser#39701 Implement SafeSign for LiFi bridge transactions (core)

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#24608

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/swap

Description Currently, the ABI decoder cannot parse cross-chain bridge transactions, which results in blind-signing Steps to reproduce 1. Go to Bridge page, and fetch a quote from LiFi 2. Create bridge transaction to popup for signing panel Actual result Incorrect transaction info is seen in the signing panel, with no details about the bridge transaction. Expected result A signing screen similar to SafeSign for EVM swaps. Reproduces how often Easily reproduced Brave version…

Timeline (10 of 13 events)
  1. 2024-07-11 16:41 Label added QA/Yes by onyb
  2. 2024-07-11 16:41 Label added release-notes/exclude by onyb
  3. 2024-07-11 16:41 Label added OS/Desktop by onyb
  4. 2024-07-11 16:42 Referenced by brave-core#24608 by onyb
  5. 2024-07-18 17:29 Closed completed brave-core#24608 by onyb
  6. 2024-07-18 17:29 Milestone set 1.70.x - Nightly by brave-builds
  7. 2024-07-18 17:32 Referenced by brave-core#24738 by brave-builds
  8. 2024-07-19 19:16 Milestone removed 1.70.x - Nightly by brave-builds
  9. 2024-07-19 19:16 Milestone set 1.69.x - Beta by brave-builds
  10. 2024-08-06 09:54 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#24608 feat(wallet): add SafeSign to LiFi bridge transactions

State: merged 2024-07-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/39701 Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (4 of 8 events)
  1. 2024-07-18 17:29 Merged master by onyb
  2. 2024-07-18 17:29 Closed by onyb
  3. 2024-07-18 17:29 Milestone set 1.70.x - Nightly by github-actions
  4. 2024-07-18 17:32 Referenced by brave-core#24738 by brave-builds
Uplift PR → 1.69.x

brave-core#24738 feat(wallet): add SafeSign to LiFi bridge transactions (uplift to 1.69.x)

State: merged 2024-07-19 · created · closed · updated · discovered via mentions:brave/brave-core#24608

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of #24608 Resolves https://github.com/brave/brave-browser/issues/39701 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 6 events)
  1. 2024-07-18 17:32 Milestone set 1.69.x - Beta by brave-builds
  2. 2024-07-19 19:16 Merged 1.69.x by kjozwiak
  3. 2024-07-19 19:16 Closed by kjozwiak