Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix build

In a Release build Issue General Zcash support

Lead item brave-browser#39688 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24600 merged 2024-07-11 into master by cypt4
    Fix build
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_39688 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: unassigned · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...203035a3: behind); later builds of the same history include it (brave-core#24600)

Members and their history

Issue

brave-browser#39688 Fix build

State: closed (completed) · created · closed · updated · discovered via search:zcash, search:zec · matched body:zcash

priority/P1 QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core

Description After 2 confilicting PRs are merged: https://github.com/brave/brave-core/pull/23076 and https://github.com/brave/brave-core/pull/24365 . [code] Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Desktop Brave version (brave://version info) - Android device - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the…

Timeline (8 of 11 events)
  1. 2024-07-11 07:44 Label added OS/Android by cypt4
  2. 2024-07-11 07:44 Label added OS/Desktop by cypt4
  3. 2024-07-11 07:45 Label added priority/P1 by cypt4
  4. 2024-07-11 07:46 Referenced by brave-core#24600 by cypt4
  5. 2024-07-11 08:39 Closed completed brave-core#24600 by mihaiplesa
  6. 2024-07-11 08:39 Milestone set 1.69.x - Nightly by brave-builds
  7. 2024-07-12 13:00 Label added QA/No by mihaiplesa
  8. 2024-07-12 13:00 Label added release-notes/exclude by mihaiplesa
Pull request

brave-core#24600 Fix build

State: merged 2024-07-11 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core

Fixes build conflict after this 2 PRs are merged : https://github.com/brave/brave-core/pull/23076 and https://github.com/brave/brave-core/pull/24365 . Resolves https://github.com/brave/brave-browser/issues/39688 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote…

Timeline (3 of 5 events)
  1. 2024-07-11 08:39 Merged master by mihaiplesa
  2. 2024-07-11 08:39 Closed by mihaiplesa
  3. 2024-07-11 08:39 Milestone set 1.69.x - Nightly by github-actions