Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Refactor wallet network prefs

In a Release build Issue General Zcash support

Lead item brave-browser#39494 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24365 merged 2024-07-10 into master by supermassive
    Network manager
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...75a8cbc0: behind); later builds of the same history include it (brave-core#24365)

Members and their history

Issue

brave-browser#39494 Refactor wallet network prefs

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#24365

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Refactor code around wallet network prefs so it is done through a single instance of NetworkManager Steps to reproduce n/a Actual result n/a Expected result n/a Reproduces how often Easily reproduced Brave version (brave://version info) n/a Channel information - [ ] release (stable) - [ ] beta - [X] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No…

Timeline (6 of 9 events)
  1. 2024-07-01 09:36 Label added OS/Desktop by supermassive
  2. 2024-07-01 09:37 Referenced by brave-core#24365 by supermassive
  3. 2024-07-10 06:13 Closed completed brave-core#24365 by supermassive
  4. 2024-07-10 06:14 Milestone set 1.69.x - Nightly by brave-builds
  5. 2024-07-17 08:56 Label added QA/No by supermassive
  6. 2024-07-17 08:56 Label added release-notes/exclude by supermassive
Pull request

brave-core#24365 Network manager

State: merged 2024-07-10 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/run-network-audit CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/39494 - Move wallet network related code from brave_wallet_utils.cc to a network_manager.cc to be managed by a single instance of NetworkManager - Remove outdated prefs migrations kBraveWalletTransactionsChainIdMigrated and kBraveWalletSolanaTransactionsV0SupportMigrated Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them -…

Timeline (6 of 11 events)
  1. 2024-07-01 09:00 Ready for review by supermassive
  2. 2024-07-10 06:13 Merged master by supermassive
  3. 2024-07-10 06:13 Closed by supermassive
  4. 2024-07-10 06:14 Milestone set 1.69.x - Nightly by github-actions
  5. 2024-07-11 10:08 Referenced by brave-core#24600 by cypt4
  6. 2024-07-11 10:08 Referenced by brave-browser#39688 by cypt4