Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Implement shielded inputs support

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#39314 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26477 merged 2024-12-13 into master by cypt4
    [ZCash ] Implement shard tree and shard storage
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#25216 closed without merge into master by cypt4
    [WIP] Shielded inputs support
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_39314_3 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...f6393b6c: behind); later builds of the same history include it (brave-core#26477)

Members and their history

Issue

brave-browser#39314 [Zcash] Implement shielded inputs support

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:shielded, body:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description 1) Implement shard_tree db layer on c++ 2) Implement ShardStore rust interface over db layer 3) Add steps to zcash block scanner to properly fill shard_tree like shard roots resolution or cmu resolution 4) Add shielded spends to transaction info 5) Add steps to sign shielded spends using shard_tree Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Desktop Brave version (brave://version info) - Android device -…

Timeline (9 of 12 events)
  1. 2024-06-24 16:34 Label added OS/Android by cypt4
  2. 2024-06-24 16:34 Label added OS/Desktop by cypt4
  3. 2024-09-17 18:38 Referenced by brave-core#25216 by cypt4
  4. 2024-11-11 17:24 Referenced by brave-core#26477 by cypt4
  5. 2024-12-13 19:24 Closed completed brave-core#26477 by cypt4
  6. 2024-12-13 19:24 Closed completed by cypt4
  7. 2024-12-13 19:24 Milestone set 1.75.x - Nightly by brave-builds
  8. 2024-12-16 13:51 Label added QA/No by cypt4
  9. 2024-12-16 13:51 Label added release-notes/exclude by cypt4
Pull request

brave-core#26477 [ZCash ] Implement shard tree and shard storage

State: merged 2024-12-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr · matched title:zcash

CI/run-network-audit CI/run-audit-deps CI/storybook-url CI/run-upstream-tests feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/39314 Crate pr : https://github.com/brave/brave-core/pull/26966 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before…

Timeline (7 of 16 events)
  1. 2024-11-13 19:48 Referenced by brave-core#26534 by cypt4
  2. 2024-12-10 17:52 Referenced by brave-browser#42794 by cypt4
  3. 2024-12-10 18:03 Referenced by brave-browser#42796 by cypt4
  4. 2024-12-12 20:13 Referenced by brave-browser#42867 by cypt4
  5. 2024-12-13 19:24 Merged master by cypt4
  6. 2024-12-13 19:24 Closed by cypt4
  7. 2024-12-13 19:24 Milestone set 1.75.x - Nightly by github-actions
Pull request

brave-core#25216 [WIP] Shielded inputs support

State: closed without merge · created · closed · updated · discovered via search:shielded is:pr · matched title:shielded

CI/run-network-audit CI/run-audit-deps CI/storybook-url CI/run-upstream-tests feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/39314 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (1 of 9 events)
  1. 2024-11-12 19:21 Closed by cypt4