Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove KeyedService from some wallet services

In a Release build Issue General Zcash support

Lead item brave-browser#39088 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24220 merged 2024-06-20 into master by supermassive
    Remove KeyedService from some wallet services
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-Android ARM (Android only)
  • QA Pass-iPhone X (iOS only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop, iOS

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...0b50112d: behind); later builds of the same history include it (brave-core#24220)

Members and their history

Issue

brave-browser#39088 Remove KeyedService from some wallet services

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#24220

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Android QA Pass - Android ARM OS/Desktop OS/iOS feature/web3/wallet/core QA Pass - iPhone X

Description Refactor some wallet's internal stuff so it uses less KeyedService classes

Timeline (12 of 14 events)
  1. 2024-06-17 10:45 Label added OS/Android by supermassive
  2. 2024-06-17 10:45 Label added OS/Desktop by supermassive
  3. 2024-06-17 10:46 Label added OS/iOS by supermassive
  4. 2024-06-17 10:46 Label added QA/Yes by supermassive
  5. 2024-06-17 10:46 Label added release-notes/exclude by supermassive
  6. 2024-06-17 10:47 Referenced by brave-core#24220 by supermassive
  7. 2024-06-20 05:03 Closed completed brave-core#24220 by supermassive
  8. 2024-06-20 05:04 Milestone set 1.69.x - Nightly by brave-builds
  9. 2024-08-14 11:28 Label added QA Pass-Win64 by srirambv
  10. 2024-08-22 09:50 Label added QA Pass - Android ARM by srirambv
  11. 2024-08-26 08:52 Label added QA Pass - iPhone X by srirambv
  12. 2026-03-26 06:06 Referenced by brave-browser#53971 by supermassive
Pull request

brave-core#24220 Remove KeyedService from some wallet services

State: merged 2024-06-20 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched body:zcashwalletservice

CI/run-network-audit CI/storybook-url needs-security-review feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/39088 I needed an entity to manage wallet's networks and it appeared I should create another KeyedService which is a wrong direction to go: - Removed inheritance from KeyedService for KeyringService, JsonRpcService, TxService, BitcoinWalletService, ZCashWalletService. Instances are now owned by BraveWalletService. Some KeyedService within wallet still there and should be also cleaned up but out of scope now. - Moved…

Timeline (5 of 11 events)
  1. 2024-06-17 15:15 Ready for review by supermassive
  2. 2024-06-20 05:03 Merged master by supermassive
  3. 2024-06-20 05:03 Closed by supermassive
  4. 2024-06-20 05:04 Milestone set 1.69.x - Nightly by github-actions
  5. 2026-02-03 21:00 Referenced by brave-core#33529 by nuo-xu