Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Editing ZEC network RPC url causes `eth_chainId` request

In a Release build Bug Sync, scanning & storage

Lead item brave-browser#38971 · opened by StephenHeaps · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24249 merged 2024-06-18 into master by yrliou
    Allow only HTTPS URLs or HTTP localhost URLs for rpc, icon, and explo…
    Linked by: GitHub closing reference

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Desktop

Owner: yrliou · PR authors: yrliou

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...1ceff065: behind); later builds of the same history include it (brave-core#24249)

Members and their history

Issue

brave-browser#38971 [ZCash] Editing ZEC network RPC url causes `eth_chainId` request

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zcash, body:zec

bug QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/zcash

Description When editing a ZEC network RPC url, after you tap Submit a eth_chainId request is made: [image] Steps to reproduce 1. Setup/run a proxy to observe network requests 2. Open brave://settings/wallet/networks 3. For either Zcash Mainnet or Zcash Testnet, click the ... and select edit 4. Change the RPC url to anything 5. Click submit Actual result eth_chainId request is made (see above screenshot) Expected result No eth_chainId request for ZEC coin type Reproduces…

Timeline (5 of 8 events)
  1. 2024-06-11 19:15 Label added OS/Desktop by StephenHeaps
  2. 2024-06-18 20:56 Label added QA/Yes by yrliou
  3. 2024-06-18 20:56 Label added release-notes/exclude by yrliou
  4. 2024-06-18 20:56 Closed completed by yrliou
  5. 2024-06-18 20:57 Linked brave-core#24249 by yrliou
Pull request

brave-core#24249 Allow only HTTPS URLs or HTTP localhost URLs for rpc, icon, and explo…

State: merged 2024-06-18 · created · closed · updated · discovered via linked:brave/brave-browser#38971

feature/web3/wallet feature/web3/wallet/core

…rer URLs Only use those URLs in: - ParseChainList for registry - JsonRPCService::AddChain Resolves https://github.com/brave/brave-browser/issues/39111 Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review…

Timeline (7 of 9 events)
  1. 2024-06-18 03:16 Converted to draft by yrliou
  2. 2024-06-18 05:44 Ready for review by yrliou
  3. 2024-06-18 17:45 Merged master by yrliou
  4. 2024-06-18 17:45 Closed by yrliou
  5. 2024-06-18 17:46 Milestone set 1.69.x - Nightly by github-actions
  6. 2024-06-18 20:56 Referenced by brave-browser#38971 by yrliou
  7. 2024-08-07 06:53 Referenced by brave-browser#39111 by srirambv