Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Wallet] Panel crashes when attempting to lookup EIP1159 estimates for non EVM or FIL transactions

In release notes Bug Transactions & fees

Lead item brave-browser#38970 · opened by josheleonard · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24134 merged 2024-06-11 into master by josheleonard
    fix(wallet): do not crash during fee estimate lookup for invalid coins
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.69.153: “Fixed panel crash which occurred when attempting to lookup EIP1159 estimates for non EVM or FIL transactions. (#38970)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: josheleonard · PR authors: josheleonard

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...6da30e88: behind); later builds of the same history include it (brave-core#24134)

Members and their history

Issue

brave-browser#38970 [Wallet] Panel crashes when attempting to lookup EIP1159 estimates for non EVM or FIL transactions

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#24134

bug crash QA Pass-Win64 QA/Yes release-notes/include feature/web3/wallet OS/Desktop

Description We should not attempt to lookup EIP1159 gas feee estimates for transactions that are not EVM or FVM types. Steps to reproduce 1. Submit a Solana transaction from the "send" screen Actual result Panel crashes Expected result Panel should not crash Reproduces how often Easily reproduced Brave version (brave://version info) 1.69.0 Chromium: 126.0.6478.40 (Developer Build) (arm64) Channel information - [ ] release (stable) - [ ] beta - [X] nightly Reproducibility -…

Timeline (10 of 13 events)
  1. 2024-06-11 19:09 Label added QA/Yes by josheleonard
  2. 2024-06-11 19:09 Label added release-notes/exclude by josheleonard
  3. 2024-06-11 19:09 Label added OS/Desktop by josheleonard
  4. 2024-06-11 19:22 Label removed release-notes/exclude by josheleonard
  5. 2024-06-11 19:22 Label added release-notes/include by josheleonard
  6. 2024-06-11 22:09 Referenced by brave-core#24134 by josheleonard
  7. 2024-06-11 23:10 Closed completed brave-core#24134 by josheleonard
  8. 2024-06-11 23:10 Milestone set 1.69.x - Nightly by brave-builds
  9. 2024-07-25 11:35 Label added QA Pass-Win64 by srirambv
  10. 2024-08-20 17:11 Referenced by brave-browser#40559 by LaurenWags
Pull request

brave-core#24134 fix(wallet): do not crash during fee estimate lookup for invalid coins

State: merged 2024-06-11 · created · closed · updated · discovered via search:zec is:pr · matched body:zec

CI/storybook-url feature/web3/wallet

Resolves https://github.com/brave/brave-browser/issues/38970 Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (5 of 7 events)
  1. 2024-06-11 22:19 Ready for review by josheleonard
  2. 2024-06-11 23:10 Merged master by josheleonard
  3. 2024-06-11 23:10 Closed by josheleonard
  4. 2024-06-11 23:10 Milestone set 1.69.x - Nightly by github-actions
  5. 2024-07-25 11:34 Referenced by brave-browser#38970 by srirambv