Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Display Loading Spinner while Generating Address

In release notes Feature Addresses, accounts & memos

Lead item brave-browser#38931 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24104 merged 2024-06-11 into master by Douglashdaniel
    feat(wallet): Add Loading Spinner to Select Account Prompt
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.69.153: “Added a loading spinner to the "Select account" prompt when address is being generated for BTC or ZCash. (#38931)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...7d873293: behind); later builds of the same history include it (brave-core#24104)

Members and their history

Issue

brave-browser#38931 Display Loading Spinner while Generating Address

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched body:zcash

enhancement QA Pass-Win64 QA/Yes release-notes/include feature-request feature/web3/wallet OS/Desktop front-end-change

Platforms Android, Linux, macOS, Windows Description When selecting an account to send Bitcoin or ZCash to, it sometimes takes a moment for the address to be generated. Currently there is no indication that the address is being generated which could cause user to keep clicking. We should add a loading spinner to the Select Account prompt while an address is being generated. https://github.com/brave/brave-browser/assets/40611140/7a45850a-2a42-479f-95f4-bd2bfa41ac9f

Timeline (8 of 12 events)
  1. 2024-06-10 19:44 Label added QA/Yes by Douglashdaniel
  2. 2024-06-10 19:44 Label added release-notes/include by Douglashdaniel
  3. 2024-06-10 19:51 Referenced by brave-core#24104 by Douglashdaniel
  4. 2024-06-11 00:25 Closed completed brave-core#24104 by Douglashdaniel
  5. 2024-06-11 00:25 Milestone set 1.69.x - Nightly by brave-builds
  6. 2024-06-13 19:01 Label added OS/Desktop by Douglashdaniel
  7. 2024-08-05 12:08 Label added QA Pass-Win64 by srirambv
  8. 2024-08-20 17:11 Referenced by brave-browser#40559 by LaurenWags
Pull request

brave-core#24104 feat(wallet): Add Loading Spinner to Select Account Prompt

State: merged 2024-06-11 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet

Description Will now display a Loading Spinner while an address is being generated in the Select Account prompt. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before…

Timeline (4 of 6 events)
  1. 2024-06-11 00:25 Merged master by Douglashdaniel
  2. 2024-06-11 00:25 Closed by Douglashdaniel
  3. 2024-06-11 00:25 Milestone set 1.69.x - Nightly by github-actions
  4. 2024-08-05 12:08 Referenced by brave-browser#38931 by srirambv