Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Select Account is not filtering by Testnet Accounts

In a Release build Bug Addresses, accounts & memos

Lead item brave-browser#38927 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24096 merged 2024-06-10 into master by Douglashdaniel
    fix(wallet): Filter Select Account by Mainnet or Testnet
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.68.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...c7c155b1: behind); later builds of the same history include it (brave-core#24096)

Members and their history

Issue

brave-browser#38927 Select Account is not filtering by Testnet Accounts

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop front-end-change

Description When selecting a Token to send, the Select Account prompt is not filtering accounts by Testnet Accounts vs Mainnet Accounts for Bitcoin, ZCash and Filecoin. Steps to reproduce 1. Go to the Send screen and select Bitcoin, Zcash or Filecoin to send. 2. When the Select Account prompt appears, it does not filter accounts based on Testnet or Mainnet. Actual result https://github.com/brave/brave-browser/assets/40611140/e489b548-9119-4361-9b67-c796ec2111b0 Expected…

Timeline (10 of 13 events)
  1. 2024-06-10 17:06 Label added QA/Yes by Douglashdaniel
  2. 2024-06-10 17:06 Label added release-notes/exclude by Douglashdaniel
  3. 2024-06-10 17:06 Label added OS/Desktop by Douglashdaniel
  4. 2024-06-10 17:17 Referenced by brave-core#24096 by Douglashdaniel
  5. 2024-06-10 21:07 Closed completed brave-core#24096 by Douglashdaniel
  6. 2024-06-10 21:08 Milestone set 1.69.x - Nightly by brave-builds
  7. 2024-06-12 07:31 Referenced by brave-core#24123 by kjozwiak
  8. 2024-06-12 07:31 Milestone removed 1.69.x - Nightly by brave-builds
  9. 2024-06-12 07:31 Milestone set 1.68.x - Beta by brave-builds
  10. 2024-06-17 06:26 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#24096 fix(wallet): Filter Select Account by Mainnet or Testnet

State: merged 2024-06-10 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet

Description Fixes a bug when selecting a Token to send, the Select Account prompt was not filtering accounts by Testnet Accounts vs Mainnet Accounts for Bitcoin, ZCash and Filecoin. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit…

Timeline (5 of 7 events)
  1. 2024-06-10 21:07 Merged master by Douglashdaniel
  2. 2024-06-10 21:07 Closed by Douglashdaniel
  3. 2024-06-10 21:07 Milestone set 1.69.x - Nightly by github-actions
  4. 2024-06-11 14:49 Referenced by brave-core#24123 by brave-builds
  5. 2024-06-17 06:26 Referenced by brave-browser#38927 by srirambv
Uplift PR → 1.68.x

brave-core#24123 fix(wallet): Filter Select Account by Mainnet or Testnet (uplift to 1.68.x)

State: merged 2024-06-12 · created · closed · updated · discovered via mentions:brave/brave-browser#38927, mentions:brave/brave-core#24096

CI/storybook-url feature/web3/wallet

Uplift of #24096 Resolves https://github.com/brave/brave-browser/issues/38927 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2024-06-11 14:49 Milestone set 1.68.x - Beta by brave-builds
  2. 2024-06-12 07:31 Merged 1.68.x by kjozwiak
  3. 2024-06-12 07:31 Closed by kjozwiak