Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Bump orchard to 0.8

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#38821 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24012 merged 2024-06-06 into master by cypt4
    Bump orchard crate to 0.8
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_38821 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.68.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...38f98819: behind); later builds of the same history include it (brave-core#24012)

Members and their history

Issue

brave-browser#38821 [ZCash] Bump orchard to 0.8

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:orchard, body:zcash_primitives

QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Orchard 0.8 is needed in zcash_primitives 0.15.1 added in https://github.com/brave/brave-browser/issues/38604 Steps to reproduce - Actual result - Expected result - Reproduces how often No steps to reproduce Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [X] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No…

Timeline (6 of 9 events)
  1. 2024-06-05 13:37 Label added OS/Desktop by cypt4
  2. 2024-06-05 14:56 Referenced by brave-core#24012 by cypt4
  3. 2024-06-06 14:07 Closed completed brave-core#24012 by cypt4
  4. 2024-06-06 14:07 Milestone set 1.68.x - Nightly by brave-builds
  5. 2024-06-10 13:33 Label added QA/No by cypt4
  6. 2024-06-10 13:33 Label added release-notes/exclude by cypt4
Pull request

brave-core#24012 Bump orchard crate to 0.8

State: merged 2024-06-06 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr · matched title:orchard

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/38821 Audit [GitHub link omitted] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a…

Timeline (4 of 7 events)
  1. 2024-06-06 14:06 Ready for review by cypt4
  2. 2024-06-06 14:07 Merged master by cypt4
  3. 2024-06-06 14:07 Closed by cypt4
  4. 2024-06-06 14:07 Milestone set 1.68.x - Nightly by github-actions