Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Unable to hide all networks for a coin type

Open Issue General Zcash support

Lead item brave-browser#38496 · opened by StephenHeaps · last source update

This issue is open on GitHub. Fixes sometimes land through pull requests that do not link the issue (for example a later refactor); this tracker follows only explicit links (closing references, “Resolves” lines, brave_<issue> branch names, uplifts and the issue timeline).

Issue state

Open

Open.

Implementation

No pull request is linked by closing keywords, GitHub’s closing references, a brave_<issue> branch name or the issue timeline.

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Desktop

Owner: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopUnknown 1.97.59no merged PR is linked, so presence in this build is unknownUnknown 1.98.47no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
AndroidUnknown 1.97.57no merged PR is linked, so presence in this build is unknownUnknown 1.98.52no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
iOSUnknown 1.96.62no merged PR is linked, so presence in this build is unknownUnknown 1.99.44no merged PR is linked, so presence in this build is unknownUnknown 1.100.7no merged PR is linked, so presence in this build is unknown

Members and their history

Issue

brave-browser#38496 Unable to hide all networks for a coin type

State: open · created · updated · discovered via search:zcash · matched body:zcash

priority/P2 feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Currently we are unable to hide all networks for a given coin type because the selected network for the coin type is removed from the list of hidden chain_ids in GetHiddenNetworks(). This creates a bug when a user de-selects all networks for a coin type (for example, Filecoin Mainnet & Filecoin Testnet, Bitcoin Mainnet & Bitcoin Testnet, or ZCash Mainnet & ZCash Testnet) during onboarding, the network will remain visible. Steps to reproduce 1. Start onboarding…

Timeline (4 of 6 events)
  1. 2024-05-22 13:46 Label added OS/Desktop by StephenHeaps
  2. 2024-05-22 16:11 Referenced by brave-browser#37740 by StephenHeaps
  3. 2024-05-24 16:19 Label added priority/P2 by jamesmudgett
  4. 2026-04-27 19:24 Referenced by brave-core#35950 by nuo-xu