Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Support import of BTC zprv extended keys

In release notes Issue Addresses, accounts & memos

Lead item brave-browser#38446 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23729 merged 2024-05-27 into master by supermassive
    Support import of BTC accounts
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.68.128: “Added the ability to import BTC accounts (BIP84) into Brave Wallet. (#38446)” changelog line
  • Android 1.68.128: “Added the ability to import BTC accounts (BIP84) into Brave Wallet. (#38446)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-Android ARM (Android only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.68.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...2b63ed6e: behind); later builds of the same history include it (brave-core#23729)

Members and their history

Issue

brave-browser#38446 Support import of BTC zprv extended keys

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#23729

QA Pass-Win64 QA/Yes release-notes/include feature/web3/wallet OS/Android QA Pass - Android ARM OS/Desktop feature/web3/wallet/bitcoin feature/web3/wallet/core

Wallet's import account ui should support import of BTC accounts in format of zprv BIP84 extended keys. https://learnmeabitcoin.com/technical/keys/hd-wallets/derivation-paths/#bip84

Timeline (13 of 16 events)
  1. 2024-05-21 14:44 Label added OS/Android by supermassive
  2. 2024-05-21 14:44 Label added OS/Desktop by supermassive
  3. 2024-05-21 14:47 Referenced by brave-core#23729 by supermassive
  4. 2024-05-21 14:49 Referenced by brave-browser#32714 by supermassive
  5. 2024-05-24 13:19 Referenced by brave-browser#38546 by StephenHeaps
  6. 2024-05-27 02:00 Closed completed brave-core#23729 by supermassive
  7. 2024-05-27 02:01 Milestone set 1.68.x - Nightly by brave-builds
  8. 2024-06-05 14:35 Label added QA/Yes by supermassive
  9. 2024-06-05 14:35 Label added release-notes/include by supermassive
  10. 2024-06-26 11:06 Label added QA Pass-Win64 by srirambv
  11. 2024-07-01 05:22 Label added QA Pass - Android ARM by srirambv
  12. 2024-07-22 12:22 Referenced by brave-browser#39913 by LaurenWags
  13. 2024-07-23 23:10 Referenced by brave-browser#39956 by hffvld
Pull request

brave-core#23729 Support import of BTC accounts

State: merged 2024-05-27 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zec is:pr

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge unverified-commits

Resolves https://github.com/brave/brave-browser/issues/38446 - Refactored KeyringService-related prefs migrations to separate file. - Refactored parts of KeyringService-related prefs related code to separate file. - Added support of bitcoin imported accounts via separate index-based keyring. Only zprv for now Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a…

Timeline (5 of 10 events)
  1. 2024-05-21 14:58 Ready for review by supermassive
  2. 2024-05-27 02:00 Merged master by supermassive
  3. 2024-05-27 02:00 Closed by supermassive
  4. 2024-05-27 02:00 Milestone set 1.68.x - Nightly by github-actions
  5. 2024-06-03 19:07 Referenced by brave-browser#38775 by StephenHeaps