Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Implement shielded balance resolution

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#38382 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24547 merged 2024-08-19 into master by cypt4
    [ZCash] ZCash shielded balance resolution
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_38382_2 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...bf6c28e1: behind); later builds of the same history include it (brave-core#24547)

Members and their history

Issue

brave-browser#38382 [ZCash] Implement shielded balance resolution

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:shielded, body:shielded

priority/P3 OS/Android OS/Desktop feature/web3/wallet/zcash

To obtain account shielded balance we need to scan blockchain from account birthday using incoming view keys. For each found note we should extract and remember nullifier to verify whether it is spent in the future .

Timeline (5 of 6 events)
  1. 2024-05-16 18:38 Label added OS/Android by cypt4
  2. 2024-05-16 18:38 Label added OS/Desktop by cypt4
  3. 2024-05-16 18:41 Label added priority/P3 by yrliou
  4. 2024-09-17 18:35 Referenced by brave-core#24547 by cypt4
  5. 2024-12-13 20:04 Closed completed by cypt4
Pull request

brave-core#24547 [ZCash] ZCash shielded balance resolution

State: merged 2024-08-19 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:zcash, title:shielded, body:orchard

CI/run-audit-deps CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Sync process includes reading blockchain blocks, resolving orchard compact actions from blocks and decoding them using account full view key. Found notes are placed to the database and note nullifier calculated to check further spends. We keep all discovered notes along with all discovered nullifiers to support possible chain reorg. In the case of reorg we just delete rows related to the blocks after the reorg chain tip. There is also a mechanic which allows to update…

Timeline (4 of 9 events)
  1. 2024-07-11 10:33 Ready for review by cypt4
  2. 2024-08-19 12:30 Merged master by cypt4
  3. 2024-08-19 12:30 Closed by cypt4
  4. 2024-08-19 12:30 Milestone set 1.71.x - Nightly by github-actions