Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Select Account Dropdown is Highlighting Multiple Accounts

In a Release build Bug Addresses, accounts & memos

Lead item brave-browser#38262 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23598 merged 2024-05-13 into master by Douglashdaniel
    fix(wallet): Select Account Dropdown Bugs
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.68.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...9b1b4f70: behind); later builds of the same history include it (brave-core#23598)

Members and their history

Issue

brave-browser#38262 Select Account Dropdown is Highlighting Multiple Accounts

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop front-end-change

Description The Select Account Dropdown is highlighting multiple accounts when filtering by Bitcoin or ZCash account Steps to Reproduce 1. Navigate to the Send screen and open the Select Token Modal 2. Filter tokens by a Bitcoin or ZCash Account 3. All Bitcoin and ZCash account will be highlighted as the selected account Actual result: [image] Expected result: Should use the accounts Unique key rather than address to fix this issue. [image] Reproduces how often: Brave…

Timeline (7 of 10 events)
  1. 2024-05-13 13:41 Label added QA/Yes by Douglashdaniel
  2. 2024-05-13 13:41 Label added release-notes/exclude by Douglashdaniel
  3. 2024-05-13 13:41 Label added OS/Desktop by Douglashdaniel
  4. 2024-05-13 13:51 Referenced by brave-core#23598 by Douglashdaniel
  5. 2024-05-13 17:18 Closed completed brave-core#23598 by Douglashdaniel
  6. 2024-05-13 17:18 Milestone set 1.68.x - Nightly by brave-builds
  7. 2024-06-12 07:56 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#23598 fix(wallet): Select Account Dropdown Bugs

State: merged 2024-05-13 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet

Description - Fixes a bug where the check icon was missing in the Select Account Dropdown. - Fixes a bug where the Select Account Dropdown was highlighting multiple accounts when filtering an account by Bitcoin or ZCash. Resolves Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR…

Timeline (5 of 7 events)
  1. 2024-05-13 17:18 Merged master by Douglashdaniel
  2. 2024-05-13 17:18 Closed by Douglashdaniel
  3. 2024-05-13 17:18 Milestone set 1.68.x - Nightly by github-actions
  4. 2024-06-12 07:56 Referenced by brave-browser#38262 by srirambv
  5. 2024-06-12 11:14 Referenced by brave-browser#38261 by srirambv