Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Store wallet's mnemonic only once in prefs

In a Release build Issue General Zcash support

Lead item brave-browser#38011 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23363 merged 2024-05-14 into master by supermassive
    Single pref for wallet mnemonic
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-Android ARM (Android only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.68.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...e153faab: behind); later builds of the same history include it (brave-core#23363)

Members and their history

Issue

brave-browser#38011 Store wallet's mnemonic only once in prefs

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#23363

QA Pass-Win64 dev-concern QA/Yes release-notes/exclude feature/web3/wallet OS/Android QA Pass - Android ARM OS/Desktop feature/web3/wallet/core

Timeline (10 of 13 events)
  1. 2024-05-02 08:04 Label added QA/Yes by supermassive
  2. 2024-05-02 08:04 Label added release-notes/exclude by supermassive
  3. 2024-05-02 08:04 Label added OS/Android by supermassive
  4. 2024-05-02 08:04 Label added OS/Desktop by supermassive
  5. 2024-05-02 08:05 Referenced by brave-core#23363 by supermassive
  6. 2024-05-14 00:59 Closed completed brave-core#23363 by supermassive
  7. 2024-05-14 00:59 Milestone set 1.68.x - Nightly by brave-builds
  8. 2024-05-21 14:49 Referenced by brave-browser#32714 by supermassive
  9. 2024-06-26 12:28 Label added QA Pass-Win64 by srirambv
  10. 2024-07-01 06:15 Label added QA Pass - Android ARM by srirambv
Pull request

brave-core#23363 Single pref for wallet mnemonic

State: merged 2024-05-14 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/storybook-url needs-security-review feature/web3/wallet feature/web3/wallet/core puLL-Merge unverified-commits

Resolves https://github.com/brave/brave-browser/issues/38011 A set of refactoring which aim to reduce complexity of keyrings/encryptors code: - There is a single pref for mnemonic - There is a single pref for encryptor's salt - There is only 'encryptor_' instance now - Each encrypted piece of data(mnemonic and all imported private keys) is stored as a dict of ciphertext and random nonce - Prefs upgrade is done when valid password is provided by user - Wallet restore is…

Timeline (7 of 13 events)
  1. 2024-05-02 08:59 Ready for review by supermassive
  2. 2024-05-14 00:59 Merged master by supermassive
  3. 2024-05-14 00:59 Closed by supermassive
  4. 2024-05-14 00:59 Milestone set 1.68.x - Nightly by github-actions
  5. 2024-05-14 01:07 Referenced by brave-browser#38280 by supermassive
  6. 2024-05-21 02:39 Referenced by brave-browser#38430 by supermassive
  7. 2024-06-26 12:28 Referenced by brave-browser#38011 by srirambv