Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix debug build on master

In a Release build Issue General Zcash support

Lead item brave-browser#37983 · opened by mkarolin · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23362 merged 2024-05-01 into master by mkarolin
    Fixes debug build.
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.67.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: mkarolin · PR authors: mkarolin

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...df0e7d52: behind); later builds of the same history include it (brave-core#23362)

Members and their history

Issue

brave-browser#37983 Fix debug build on master

State: closed (completed) · created · closed · updated · discovered via search:orchard wallet, search:zcash · matched body:zcash

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

On Windows debug build errors out with: [code]

Timeline (6 of 9 events)
  1. 2024-05-01 05:15 Label added QA/No by mkarolin
  2. 2024-05-01 05:15 Label added release-notes/exclude by mkarolin
  3. 2024-05-01 05:15 Label added OS/Desktop by mkarolin
  4. 2024-05-01 05:18 Referenced by brave-core#23362 by mkarolin
  5. 2024-05-01 18:53 Closed completed brave-core#23362 by mkarolin
  6. 2024-05-01 18:53 Milestone set 1.67.x - Nightly by mkarolin
Pull request

brave-core#23362 Fixes debug build.

State: merged 2024-05-01 · created · closed · updated · discovered via linked:brave/brave-browser#37983

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/37983 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (3 of 5 events)
  1. 2024-05-01 18:53 Merged master by mkarolin
  2. 2024-05-01 18:53 Closed by mkarolin
  3. 2024-05-01 18:53 Milestone set 1.67.x - Nightly by mkarolin