Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Refactor wallet keyrings

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#37613 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23075 merged 2024-04-18 into master by supermassive
    Keyrings refactoring
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-Android ARM (Android only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.67.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: unassigned · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...719f2cf7: behind); later builds of the same history include it (brave-core#23075)

Members and their history

Issue

brave-browser#37613 Refactor wallet keyrings

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#23075

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Android QA Pass - Android ARM OS/Desktop feature/web3/wallet/bitcoin feature/web3/wallet/core

Need some overhaul for further bitcoin imported accounts keyring.

Timeline (10 of 13 events)
  1. 2024-04-16 11:27 Label added OS/Android by supermassive
  2. 2024-04-16 11:27 Label added OS/Desktop by supermassive
  3. 2024-04-16 11:27 Referenced by brave-browser#32714 by supermassive
  4. 2024-04-16 11:28 Referenced by brave-core#23075 by supermassive
  5. 2024-04-18 08:47 Closed completed brave-core#23075 by supermassive
  6. 2024-04-18 08:48 Milestone set 1.67.x - Nightly by brave-builds
  7. 2024-04-25 02:30 Label added QA/Yes by supermassive
  8. 2024-04-25 02:30 Label added release-notes/exclude by supermassive
  9. 2024-05-27 09:48 Label added QA Pass-Win64 by srirambv
  10. 2024-05-30 12:44 Label added QA Pass - Android ARM by srirambv
Pull request

brave-core#23075 Keyrings refactoring

State: merged 2024-04-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/37613 Set of changes to reduce complexity a bit. Preparation to add bitcoin imported accounts keyring. 1) Remove HDKeyBase base class. HDKey and HDKeyEd25519 have more differences than similarities. Benefits of having some shared code based on HDKeyBase don't outweigh complexities of tight coupling(could be measured by amount of static_cast's). 2) Added Secp256k1HDKeyring which is a base class for all keyrings except…

Timeline (6 of 11 events)
  1. 2024-04-16 11:29 Ready for review by supermassive
  2. 2024-04-17 23:29 Referenced by brave-core#22870 by darkdh
  3. 2024-04-18 08:47 Merged master by supermassive
  4. 2024-04-18 08:47 Closed by supermassive
  5. 2024-04-18 08:48 Milestone set 1.67.x - Nightly by github-actions
  6. 2024-05-27 09:47 Referenced by brave-browser#37613 by srirambv