Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Shielding operation

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#37201 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23076 merged 2024-07-11 into master by cypt4
    Implement shielding
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_37201_7 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...faa4ae02: behind); later builds of the same history include it (brave-core#23076)

Members and their history

Issue

brave-browser#37201 [ZCash] Shielding operation

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

priority/P3 QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Implement sending from t->s

Timeline (9 of 13 events)
  1. 2024-03-29 07:25 Label added OS/Desktop by cypt4
  2. 2024-03-29 07:25 Label added priority/P4 by cypt4
  3. 2024-04-15 10:39 Referenced by brave-core#23076 by cypt4
  4. 2024-04-19 13:07 Label added priority/P3 by cypt4
  5. 2024-07-11 07:03 Closed completed brave-core#23076 by cypt4
  6. 2024-07-11 07:03 Closed completed by cypt4
  7. 2024-07-11 07:03 Label added QA/No by cypt4
  8. 2024-07-11 07:03 Label added release-notes/exclude by cypt4
  9. 2024-07-11 07:03 Milestone set 1.69.x - Nightly by brave-builds
Pull request

brave-core#23076 Implement shielding

State: merged 2024-07-11 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:lightwalletd is:pr, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched body:zcashtransaction

CI/run-audit-deps CI/storybook-url needs-security-review feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/37201 Adds shielding operations which means sending from transparent to shielded address. See last commit until PR rebased on master. This includes steps : Create Tx flow: - Resolve transparent UTXOs for the selected account, also resolve last orchard tree root ( This is needed to construct Orchard tx bundle ) and latest block id(needed for tx header). - Construct unauthorized orchard bundle with provided shielded…

Timeline (7 of 13 events)
  1. 2024-04-15 15:07 Ready for review by cypt4
  2. 2024-06-05 13:05 Referenced by brave-core#23892 by cypt4
  3. 2024-07-11 07:03 Merged master by cypt4
  4. 2024-07-11 07:03 Closed by cypt4
  5. 2024-07-11 07:03 Milestone set 1.69.x - Nightly by github-actions
  6. 2024-07-11 10:08 Referenced by brave-core#24600 by cypt4
  7. 2024-07-11 10:08 Referenced by brave-browser#39688 by cypt4