Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Add Orchard crate

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#36128 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#22864 merged 2024-04-29 into master by cypt4
    Add orchard crate
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_36128 (weaker evidence; titles share a keyword)
  • brave-core#22097 closed without merge into master by cypt4
    Orchard crate
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_36128 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.67.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...122e27b5: behind); later builds of the same history include it (brave-core#22864)

Members and their history

Issue

brave-browser#36128 [ZCash] Add Orchard crate

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:orchard

priority/P3 QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Timeline (10 of 14 events)
  1. 2024-02-15 17:57 Label added OS/Android by cypt4
  2. 2024-02-15 17:57 Label added OS/Desktop by cypt4
  3. 2024-02-16 17:22 Label added priority/P4 by jamesmudgett
  4. 2024-02-16 18:08 Referenced by brave-core#22097 by cypt4
  5. 2024-04-03 06:56 Referenced by brave-core#22864 by cypt4
  6. 2024-04-19 13:08 Label added priority/P3 by cypt4
  7. 2024-04-29 18:57 Closed completed brave-core#22864 by cypt4
  8. 2024-04-29 18:57 Milestone set 1.67.x - Nightly by brave-builds
  9. 2024-05-13 16:02 Label added QA/No by cypt4
  10. 2024-05-13 16:02 Label added release-notes/exclude by cypt4
Pull request

brave-core#22864 Add orchard crate

State: merged 2024-04-29 · created · closed · updated · discovered via search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:orchard, body:zcash

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/36128 This PR adds Orchard crate for the further ZCash shielded addresses support. Crate provides functions for generating different types of keys&addresses, Orchard tx part generation, spending notes decoding. In this PR only the crate with buildflag is added. Audit [GitHub link omitted] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I…

Timeline (5 of 8 events)
  1. 2024-04-15 20:46 Referenced by brave-core#22870 by cypt4
  2. 2024-04-18 08:53 Referenced by brave-browser#37680 by cypt4
  3. 2024-04-29 18:57 Merged master by cypt4
  4. 2024-04-29 18:57 Closed by cypt4
  5. 2024-04-29 18:57 Milestone set 1.67.x - Nightly by github-actions
Pull request

brave-core#22097 Orchard crate

State: closed without merge · created · closed · updated · discovered via search:orchard is:pr, search:zcash is:pr · matched title:orchard, body:zcash_spec

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/36128 Deps review for Orchard 0.6 [GitHub link omitted] This PR presents orchard 0.7 which has a couple more deps : zcash_spec = "0.1" zip32 = "0.1" Also rayon is disabled, so currently no multi-threading here. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github…

Timeline (4 of 7 events)
  1. 2024-02-19 13:32 Ready for review by cypt4
  2. 2024-02-29 14:15 Referenced by brave-core#22396 by cypt4
  3. 2024-04-01 11:31 Closed by cypt4
  4. 2024-04-02 08:05 Referenced by brave-core#22864 by cypt4