Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Show error message when unified address without transparent part provided

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#35923 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21982 merged 2024-02-19 into master by cypt4
    Add error message for UA without transparent part
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_35923 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.65.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...b61415ef: behind); later builds of the same history include it (brave-core#21982)

Members and their history

Issue

brave-browser#35923 [Zcash] Show error message when unified address without transparent part provided

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:unified address

QA Pass-Win64 priority/P4 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Timeline (9 of 13 events)
  1. 2024-02-09 14:44 Label added QA/Yes by cypt4
  2. 2024-02-09 14:44 Label added release-notes/exclude by cypt4
  3. 2024-02-09 14:44 Label added OS/Android by cypt4
  4. 2024-02-09 14:44 Label added OS/Desktop by cypt4
  5. 2024-02-12 17:17 Referenced by brave-core#21982 by cypt4
  6. 2024-02-16 17:22 Label added priority/P4 by jamesmudgett
  7. 2024-02-19 18:20 Closed completed brave-core#21982 by cypt4
  8. 2024-02-19 18:20 Milestone set 1.65.x - Nightly by brave-builds
  9. 2024-03-27 07:49 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21982 Add error message for UA without transparent part

State: merged 2024-02-19 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash · matched body:unified addresses

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Additional address verification added and used in the UI instead of simple regex check. This allows to check not only address format but also checksum and check whether UA contains transparent part. Resolves https://github.com/brave/brave-browser/issues/35923 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing…

Timeline (5 of 8 events)
  1. 2024-02-12 14:58 Ready for review by cypt4
  2. 2024-02-19 18:20 Merged master by cypt4
  3. 2024-02-19 18:20 Closed by cypt4
  4. 2024-02-19 18:20 Milestone set 1.65.x - Nightly by github-actions
  5. 2024-03-27 07:49 Referenced by brave-browser#35923 by srirambv