Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Wrong transparent part extracted from the unified address

In a Release build Bug Addresses, accounts & memos

Lead item brave-browser#35883 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21960 merged 2024-02-09 into master by cypt4
    Extract transparent part using pubkey hash instead of pubkey in UA
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_35883 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.64.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...31714086: behind); later builds of the same history include it (brave-core#21960)

Members and their history

Issue

brave-browser#35883 Wrong transparent part extracted from the unified address

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash · matched label:feature/web3/wallet/zcash, title:unified address, body:unified address

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Sending transaction to Unified address shows sucess but balance doesn't update Steps to Reproduce 1. Submit a transaction to Unified address that includes transparent address 2. Transaction is successful 3. Check balance of unified address, doesn't show the transfer balance Actual result: Sending transaction to Unified address shows sucess but balance doesn't update Expected result: Should show the balance Reproduces how often: Easy Brave version…

Timeline (7 of 11 events)
  1. 2024-02-08 11:48 Label added QA/Yes by srirambv
  2. 2024-02-08 11:48 Label added release-notes/exclude by srirambv
  3. 2024-02-08 11:48 Label added OS/Desktop by srirambv
  4. 2024-02-08 16:09 Referenced by brave-core#21960 by cypt4
  5. 2024-02-09 07:58 Closed completed brave-core#21960 by cypt4
  6. 2024-02-09 07:58 Milestone set 1.64.x - Nightly by brave-builds
  7. 2024-03-14 11:27 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21960 Extract transparent part using pubkey hash instead of pubkey in UA

State: merged 2024-02-09 · created · closed · updated · discovered via search:shielded is:pr · matched body:unified address

feature/web3/wallet feature/web3/wallet/core

Problem is that wrong transparent address was extracted from the provided unified address When sending from Brave Wallet to YWallet for ex. Unified address contains pubkey hash part instead of pubkey. Resolves https://github.com/brave/brave-browser/issues/35883 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github…

Timeline (4 of 6 events)
  1. 2024-02-08 16:09 Ready for review by cypt4
  2. 2024-02-09 07:58 Merged master by cypt4
  3. 2024-02-09 07:58 Closed by cypt4
  4. 2024-02-09 07:58 Milestone set 1.64.x - Nightly by github-actions